Re: [PATCH v3 0/2] regulator: core: Fix ops->enable/disable usage

2014-02-24 Thread Fabio Estevam
On Mon, Feb 24, 2014 at 10:34 PM, Mark Brown wrote: > On Mon, Feb 24, 2014 at 09:50:58PM +0100, Markus Pargmann wrote: > >> The only situation where this returns -EINVAL is a dummy regulator that >> is not always_on. As it doesn't make sense to have a dummy regulator >> that is not always_on, I wi

Re: [PATCH v3 0/2] regulator: core: Fix ops->enable/disable usage

2014-02-24 Thread Mark Brown
On Mon, Feb 24, 2014 at 09:50:58PM +0100, Markus Pargmann wrote: > The only situation where this returns -EINVAL is a dummy regulator that > is not always_on. As it doesn't make sense to have a dummy regulator > that is not always_on, I will add a check for exactly this situation to > the regulato

Re: [PATCH v3 0/2] regulator: core: Fix ops->enable/disable usage

2014-02-24 Thread Markus Pargmann
Hi Fabio, On Mon, Feb 24, 2014 at 02:23:50PM -0300, Fabio Estevam wrote: > On Sun, Feb 23, 2014 at 2:12 AM, Mark Brown wrote: > > On Thu, Feb 20, 2014 at 05:36:02PM +0100, Markus Pargmann wrote: > >> Hi, > >> > >> These two patches replace all ops->enable/disable by > >> _regulator_do_disable/ena

Re: [PATCH v3 0/2] regulator: core: Fix ops->enable/disable usage

2014-02-24 Thread Fabio Estevam
On Sun, Feb 23, 2014 at 2:12 AM, Mark Brown wrote: > On Thu, Feb 20, 2014 at 05:36:02PM +0100, Markus Pargmann wrote: >> Hi, >> >> These two patches replace all ops->enable/disable by >> _regulator_do_disable/enable function calls. These wrappers also handle gpio >> regulators. > > Applied both, t

Re: [PATCH v3 0/2] regulator: core: Fix ops->enable/disable usage

2014-02-22 Thread Mark Brown
On Thu, Feb 20, 2014 at 05:36:02PM +0100, Markus Pargmann wrote: > Hi, > > These two patches replace all ops->enable/disable by > _regulator_do_disable/enable function calls. These wrappers also handle gpio > regulators. Applied both, thanks. signature.asc Description: Digital signature

[PATCH v3 0/2] regulator: core: Fix ops->enable/disable usage

2014-02-20 Thread Markus Pargmann
Hi, These two patches replace all ops->enable/disable by _regulator_do_disable/enable function calls. These wrappers also handle gpio regulators. v3 adds a comment about the moved _notifier_call_chain() function calls and removes a unused variable from the core driver in patch 2 (Replace direct o