Re: [PATCH v3 -tip 1/5] x86, MSI: Support multiple MSIs in presense of IRQ remapping

2012-10-04 Thread Ingo Molnar
* Alexander Gordeev wrote: > On Tue, Oct 02, 2012 at 01:25:24PM +0200, Ingo Molnar wrote: > > > > > @@ -584,8 +586,12 @@ int __irq_alloc_descs(int irq, unsigned int > > > > > from, unsigned int cnt, int node, > > > > > #define irq_alloc_desc_from(from, node) \ > > > > > irq_

Re: [PATCH v3 -tip 1/5] x86, MSI: Support multiple MSIs in presense of IRQ remapping

2012-10-04 Thread Alexander Gordeev
On Tue, Oct 02, 2012 at 01:25:24PM +0200, Ingo Molnar wrote: > > > > @@ -584,8 +586,12 @@ int __irq_alloc_descs(int irq, unsigned int from, > > > > unsigned int cnt, int node, > > > > #define irq_alloc_desc_from(from, node)\ > > > > irq_alloc_descs(-1, from, 1, node) > > >

Re: [PATCH v3 -tip 1/5] x86, MSI: Support multiple MSIs in presense of IRQ remapping

2012-10-02 Thread Ingo Molnar
* Alexander Gordeev wrote: > On Tue, Oct 02, 2012 at 06:55:18AM +0200, Ingo Molnar wrote: > > Thanks for the review, Ingo. > > > > @@ -584,8 +586,12 @@ int __irq_alloc_descs(int irq, unsigned int from, > > > unsigned int cnt, int node, > > > #define irq_alloc_desc_from(from, node) \

Re: [PATCH v3 -tip 1/5] x86, MSI: Support multiple MSIs in presense of IRQ remapping

2012-10-02 Thread Alexander Gordeev
On Tue, Oct 02, 2012 at 06:55:18AM +0200, Ingo Molnar wrote: Thanks for the review, Ingo. > > @@ -584,8 +586,12 @@ int __irq_alloc_descs(int irq, unsigned int from, > > unsigned int cnt, int node, > > #define irq_alloc_desc_from(from, node)\ > > irq_alloc_descs(-1, from, 1, node

Re: [PATCH v3 -tip 1/5] x86, MSI: Support multiple MSIs in presense of IRQ remapping

2012-10-01 Thread Ingo Molnar
* Alexander Gordeev wrote: > The MSI specification has several constraints in comparison with MSI-X, > most notable of them is the inability to configure MSIs independently. > As a result, it is impossible to dispatch interrupts from different > queues to different CPUs. This is largely devalues

[PATCH v3 -tip 1/5] x86, MSI: Support multiple MSIs in presense of IRQ remapping

2012-10-01 Thread Alexander Gordeev
The MSI specification has several constraints in comparison with MSI-X, most notable of them is the inability to configure MSIs independently. As a result, it is impossible to dispatch interrupts from different queues to different CPUs. This is largely devalues the support of multiple MSIs in SMP s