Re: [PATCH v3] zram: extend zero pages to same element pages

2017-01-22 Thread Minchan Kim
On Mon, Jan 23, 2017 at 02:17:23PM +0800, zhouxianrong wrote: > i am not sure as well about reverse hurting cache. > > On 2017/1/23 14:13, Joonsoo Kim wrote: > >On Mon, Jan 23, 2017 at 01:47:20PM +0900, Minchan Kim wrote: > >>Hello, > >> > >>When I look at first patch, I wanted to use increment lo

Re: [PATCH v3] zram: extend zero pages to same element pages

2017-01-22 Thread zhouxianrong
i am not sure as well about reverse hurting cache. On 2017/1/23 14:13, Joonsoo Kim wrote: On Mon, Jan 23, 2017 at 01:47:20PM +0900, Minchan Kim wrote: Hello, When I look at first patch, I wanted to use increment loop but didn't tell to you because that small piece of code is no harmful for rea

Re: [PATCH v3] zram: extend zero pages to same element pages

2017-01-22 Thread Joonsoo Kim
On Mon, Jan 23, 2017 at 01:47:20PM +0900, Minchan Kim wrote: > Hello, > > When I look at first patch, I wanted to use increment loop but didn't > tell to you because that small piece of code is no harmful for readbility > to me so I want to keep author's code rather than pointing the trivial > whi

Re: [PATCH v3] zram: extend zero pages to same element pages

2017-01-22 Thread Minchan Kim
Hello, When I look at first patch, I wanted to use increment loop but didn't tell to you because that small piece of code is no harmful for readbility to me so I want to keep author's code rather than pointing the trivial which is just matter of preference out. Rather than readiblity, I suspect i

Re: [PATCH v3] zram: extend zero pages to same element pages

2017-01-22 Thread zhouxianrong
the purpose for reverse iteration is that i want compiler compose decreasing instruction and compared instruction with zero into one instruction which change cpu condition state. yes, this maybe cause cache problem so need to be reviewed. thanks On 2017/1/23 11:02, Joonsoo Kim wrote: On Mon, Ja

Re: [PATCH v3] zram: extend zero pages to same element pages

2017-01-22 Thread Joonsoo Kim
On Mon, Jan 23, 2017 at 10:55:23AM +0900, Minchan Kim wrote: > From: zhouxianrong > > the idea is that without doing more calculations we extend zero pages > to same element pages for zram. zero page is special case of > same element page with zero element. > > 1. the test is done under android

[PATCH v3] zram: extend zero pages to same element pages

2017-01-22 Thread Minchan Kim
From: zhouxianrong the idea is that without doing more calculations we extend zero pages to same element pages for zram. zero page is special case of same element page with zero element. 1. the test is done under android 7.0 2. startup too many applications circularly 3. sample the zero pages, s