Re: [PATCH v3] zram: break the strict dependency from lzo

2020-10-28 Thread Sergey Senozhatsky
Hi, On (20/10/28 23:11), Rui Salvaterra wrote: > Hi, again, > > On Wed, 28 Oct 2020 at 18:22, Sergey Senozhatsky > wrote: > > > > Right, but well we also need to select ZSMALLOC and CRYPTO for > > zram to become visible (the thing that I found out recently is > > that you can always check the hi

Re: [PATCH v3] zram: break the strict dependency from lzo

2020-10-28 Thread Rui Salvaterra
Hi, again, On Wed, 28 Oct 2020 at 18:22, Sergey Senozhatsky wrote: > > Right, but well we also need to select ZSMALLOC and CRYPTO for > zram to become visible (the thing that I found out recently is > that you can always check the hidden/blocked items by hitting > 'z' in menuconfig). Sure, I can

Re: [PATCH v3] zram: break the strict dependency from lzo

2020-10-28 Thread Rui Salvaterra
Hi, Sergey, On Wed, 28 Oct 2020 at 10:19, Sergey Senozhatsky wrote: > > Can the following work then? Almost! See below. :) > Completely untested. > > ===8<=== > > diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig > index fe7a4b7d30cf..f93eed40e155 100644 > --- a/drivers/block

Re: [PATCH v3] zram: break the strict dependency from lzo

2020-10-28 Thread Sergey Senozhatsky
Hi, On (20/10/28 11:25), Rui Salvaterra wrote: > > diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig > > index fe7a4b7d30cf..f93eed40e155 100644 > > --- a/drivers/block/zram/Kconfig > > +++ b/drivers/block/zram/Kconfig > > @@ -2,7 +2,7 @@ > > config ZRAM > > tristate "C

Re: [PATCH v3] zram: break the strict dependency from lzo

2020-10-28 Thread Sergey Senozhatsky
Hi, On (20/10/27 08:39), Rui Salvaterra wrote: > Personally, I always use zram with zstd, and the only lzo dependency I > have is zram. Disabling lzo saves me about 3 kiB in the final > (xz-compressed) vmlinuz image. It's not much, for sure, but when your > total storage is 4 MiB (and your RAM is

Re: [PATCH v3] zram: break the strict dependency from lzo

2020-10-27 Thread Rui Salvaterra
Hi, Sergey, On Tue, 27 Oct 2020 at 01:22, Sergey Senozhatsky wrote: > > Honestly, I'm not entirely excited. lzo is a fallback compression > algorithm. If you want to use zram with something else thenconfigure > zram to use something else. What do all these #if/#elif buy us? The idea is to allow

Re: [PATCH v3] zram: break the strict dependency from lzo

2020-10-26 Thread Sergey Senozhatsky
On (20/10/26 08:51), Rui Salvaterra wrote: > static const char * const backends[] = { > +#if IS_ENABLED(CONFIG_CRYPTO_LZO) > "lzo", > "lzo-rle", > +#endif > #if IS_ENABLED(CONFIG_CRYPTO_LZ4) > "lz4", > #endif [..] > +static const char *default_compressor = > +#if IS_ENABLED(CON

[PATCH v3] zram: break the strict dependency from lzo

2020-10-26 Thread Rui Salvaterra
There's nothing special about zram and lzo. It works just fine without it, so as long as at least one of the other supported compression algorithms is selected. Signed-off-by: Rui Salvaterra --- v3: fix the default selection when lzo isn't present. Rebase against 5.10-rc1. v2: fix the dependency