Re: [PATCH v3] x86: bitops: fix build regression

2020-05-08 Thread Brian Gerst
On Fri, May 8, 2020 at 2:06 PM Nick Desaulniers wrote: > > This is easily reproducible via CC=clang+CONFIG_STAGING=y+CONFIG_VT6656=m. > > It turns out that if your config tickles __builtin_constant_p via > differences in choices to inline or not, these statements produce > invalid assembly: > > $

Re: [PATCH v3] x86: bitops: fix build regression

2020-05-08 Thread Nick Desaulniers
On Fri, May 8, 2020 at 11:06 AM Nick Desaulniers wrote: > > This is easily reproducible via CC=clang+CONFIG_STAGING=y+CONFIG_VT6656=m. > > It turns out that if your config tickles __builtin_constant_p via > differences in choices to inline or not, these statements produce > invalid assembly: > > $

[PATCH v3] x86: bitops: fix build regression

2020-05-08 Thread Nick Desaulniers
This is easily reproducible via CC=clang+CONFIG_STAGING=y+CONFIG_VT6656=m. It turns out that if your config tickles __builtin_constant_p via differences in choices to inline or not, these statements produce invalid assembly: $ cat foo.c long a(long b, long c) { asm("orb\t%1, %0" : "+q"(c): "r"(