Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers

2014-05-07 Thread One Thousand Gnomes
> I guess I don't see why the module isn't removable. Of course, any > driver which calls iosf_mbi_available() will depend on it, preventing > removal until *those* modules have been removed... Going back over the current version you could unload it but you rely upon the iosf_mbi_available caller

Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers

2014-05-07 Thread David E. Box
On Wed, May 07, 2014 at 06:10:42PM +0100, One Thousand Gnomes wrote: > On Wed, 07 May 2014 10:04:56 -0700 > "H. Peter Anvin" wrote: > > > On 05/07/2014 09:48 AM, One Thousand Gnomes wrote: > > > On Fri, 2 May 2014 10:36:39 -0700 > > >> +bool iosf_mbi_available(void) > > >> +{ > > >> +ret

Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers

2014-05-07 Thread H. Peter Anvin
On 05/07/2014 10:10 AM, One Thousand Gnomes wrote: > On Wed, 07 May 2014 10:04:56 -0700 > "H. Peter Anvin" wrote: > >> On 05/07/2014 09:48 AM, One Thousand Gnomes wrote: >>> On Fri, 2 May 2014 10:36:39 -0700 +bool iosf_mbi_available(void) +{ + return mbi_pdev; +} +EXPOR

Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers

2014-05-07 Thread One Thousand Gnomes
On Wed, 07 May 2014 10:04:56 -0700 "H. Peter Anvin" wrote: > On 05/07/2014 09:48 AM, One Thousand Gnomes wrote: > > On Fri, 2 May 2014 10:36:39 -0700 > >> +bool iosf_mbi_available(void) > >> +{ > >> + return mbi_pdev; > >> +} > >> +EXPORT_SYMBOL(iosf_mbi_available); > > > > Probably worth a fo

Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers

2014-05-07 Thread H. Peter Anvin
On 05/07/2014 09:48 AM, One Thousand Gnomes wrote: > On Fri, 2 May 2014 10:36:39 -0700 >> +bool iosf_mbi_available(void) >> +{ >> +return mbi_pdev; >> +} >> +EXPORT_SYMBOL(iosf_mbi_available); > > Probably worth a follow up patch that comments this so the assumption > that iosf can never be u

Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers

2014-05-07 Thread One Thousand Gnomes
On Fri, 2 May 2014 10:36:39 -0700 > +bool iosf_mbi_available(void) > +{ > + return mbi_pdev; > +} > +EXPORT_SYMBOL(iosf_mbi_available); Probably worth a follow up patch that comments this so the assumption that iosf can never be unloaded or hot-unplugged is clear. Alan -- To unsubscribe from

[PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers

2014-05-02 Thread David E. Box
From: "David E. Box" Currently drivers that run on non-IOSF systems (Core/Xeon) can't use the IOSF driver on SOC's without selecting it which forces an unnecessary and limiting dependency. Provides dummy functions to allow these modules to conditionally use the driver on IOSF equipped platforms w