Re: [PATCH v3] x86/fsgsbase/64: Fix the base write helper functions

2018-11-14 Thread Bae, Chang Seok
On Nov 6, 2018, at 17:23, Andy Lutomirski wrote: > > On Thu, Nov 1, 2018 at 1:32 PM Chang S. Bae wrote: >> >> @@ -392,12 +384,7 @@ int x86_fsbase_write_task(struct task_struct *task, >> unsigned long fsbase) >>if (unlikely(fsbase >= TASK_SIZE_MAX)) >>return -EPERM; >>

Re: [PATCH v3] x86/fsgsbase/64: Fix the base write helper functions

2018-11-06 Thread Andy Lutomirski
On Thu, Nov 1, 2018 at 1:32 PM Chang S. Bae wrote: > > The helper functions that purport to write the base should just write it > only. It shouldn't have magic optimizations to change the index. > > Make the index explicitly changed from the caller, instead of including > the code in the helpers.

[PATCH v3] x86/fsgsbase/64: Fix the base write helper functions

2018-11-01 Thread Chang S. Bae
The helper functions that purport to write the base should just write it only. It shouldn't have magic optimizations to change the index. Make the index explicitly changed from the caller, instead of including the code in the helpers. v2: Fix further on the task write functions. Revert the change