Re: [PATCH v3] tty: add missing rcu_read_lock for task_pgrp

2015-07-12 Thread Patrick Donnelly
On Sat, Jul 11, 2015 at 10:05 PM, Peter Hurley wrote: > I just realized there's a missing rcu_read_unlock() from this early return. Nice catch. I'll send a new series out... -- Patrick Donnelly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

Re: [PATCH v3] tty: add missing rcu_read_lock for task_pgrp

2015-07-11 Thread Peter Hurley
On 06/29/2015 07:59 PM, Patrick Donnelly wrote: > task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the > duration of use. > > Signed-off-by: Patrick Donnelly > --- > drivers/tty/n_tty.c | 12 +

Re: [PATCH v3] tty: add missing rcu_read_lock for task_pgrp

2015-07-08 Thread Peter Hurley
On 06/29/2015 07:59 PM, Patrick Donnelly wrote: > task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the > duration of use. Reviewed-by: Peter Hurley -- To unsubscribe from this list: send the line "

[PATCH v3] tty: add missing rcu_read_lock for task_pgrp

2015-06-29 Thread Patrick Donnelly
task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the duration of use. Signed-off-by: Patrick Donnelly --- drivers/tty/n_tty.c | 12 ++-- drivers/tty/tty_io.c | 17 - 2 files