Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline

2017-09-19 Thread Steven Rostedt
On Tue, 12 Sep 2017 20:18:35 +0800 "Ziqian SUN (Zamir)" wrote: > >> I feel the core trace printed by WARN is not so meaningful, so I use > >> pr_warn instead. > > > > I'm fine with pr_warn, but I'm curious to what you mean by "not so > > meaningful"? A WARN() will cause a dump stack, which usu

Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline

2017-09-18 Thread Ziqian SUN (Zamir)
On 09/12/2017 08:18 PM, Ziqian SUN (Zamir) wrote: On 09/11/2017 07:23 PM, Steven Rostedt wrote: On Mon, 11 Sep 2017 14:31:34 +0800 "Ziqian SUN (Zamir)" wrote: On 09/11/2017 02:26 PM, Ziqian SUN (Zamir) wrote: From: "Ziqian SUN (Zamir)" The mmiotrace tracer cannot be enabled with ftrace

Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline

2017-09-12 Thread Ziqian SUN (Zamir)
On 09/11/2017 07:23 PM, Steven Rostedt wrote: On Mon, 11 Sep 2017 14:31:34 +0800 "Ziqian SUN (Zamir)" wrote: On 09/11/2017 02:26 PM, Ziqian SUN (Zamir) wrote: From: "Ziqian SUN (Zamir)" The mmiotrace tracer cannot be enabled with ftrace=mmiotrace in kernel commandline. With this patch, no

Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline

2017-09-11 Thread Steven Rostedt
On Mon, 11 Sep 2017 14:31:34 +0800 "Ziqian SUN (Zamir)" wrote: > On 09/11/2017 02:26 PM, Ziqian SUN (Zamir) wrote: > > From: "Ziqian SUN (Zamir)" > > > > The mmiotrace tracer cannot be enabled with ftrace=mmiotrace in kernel > > commandline. With this patch, noboot is added to the tracer struct

Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline

2017-09-10 Thread Ziqian SUN (Zamir)
On 09/11/2017 02:26 PM, Ziqian SUN (Zamir) wrote: From: "Ziqian SUN (Zamir)" The mmiotrace tracer cannot be enabled with ftrace=mmiotrace in kernel commandline. With this patch, noboot is added to the tracer struct, and when system boot with a tracer that has noboot=true, it will print out a w

[PATCH v3] tracing: Ignore mmiotrace from kernel commandline

2017-09-10 Thread Ziqian SUN (Zamir)
From: "Ziqian SUN (Zamir)" The mmiotrace tracer cannot be enabled with ftrace=mmiotrace in kernel commandline. With this patch, noboot is added to the tracer struct, and when system boot with a tracer that has noboot=true, it will print out a warning message and continue booting. Signed-off-by: