Re: [PATCH v3] sound: pci: emu10k1: code refactoring

2013-10-17 Thread Takashi Iwai
At Thu, 17 Oct 2013 19:57:12 -0300, Geyslan G. Bem wrote: > > Partially restructures _snd_emu10k1_audigy_init_efx() and > _snd_emu10k1_init_efx() functions. > > Be noted that the cast is demanded to use '__user'. So, in these cases, > avoid patches based on the coccinelle 'drop_kmalloc_cast' sema

[PATCH v3] sound: pci: emu10k1: code refactoring

2013-10-17 Thread Geyslan G. Bem
Partially restructures _snd_emu10k1_audigy_init_efx() and _snd_emu10k1_init_efx() functions. Be noted that the cast is demanded to use '__user'. So, in these cases, avoid patches based on the coccinelle 'drop_kmalloc_cast' semantic patch. Signed-off-by: Geyslan G. Bem --- sound/pci/emu10k1/emuf

Re: [PATCH v3] sound: pci: emu10k1: code refactoring and casting removal

2013-10-17 Thread Takashi Iwai
At Thu, 17 Oct 2013 12:35:31 -0300, Geyslan G. Bem wrote: > > Partially restructures _snd_emu10k1_audigy_init_efx() and > _snd_emu10k1_init_efx() functions. > > Removes useless casting (void *) from value returned by kcalloc; > see Documentation/CodingStyle, Chap 14. > > Signed-off-by: Geyslan G

[PATCH v3] sound: pci: emu10k1: code refactoring and casting removal

2013-10-17 Thread Geyslan G. Bem
Partially restructures _snd_emu10k1_audigy_init_efx() and _snd_emu10k1_init_efx() functions. Removes useless casting (void *) from value returned by kcalloc; see Documentation/CodingStyle, Chap 14. Signed-off-by: Geyslan G. Bem --- sound/pci/emu10k1/emufx.c | 76