Re: [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

2016-04-04 Thread Kefeng Wang
On 2016/4/5 12:02, Greg Kroah-Hartman wrote: > On Tue, Apr 05, 2016 at 11:32:46AM +0800, Kefeng Wang wrote: >> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate >> with new dw8250_check_lcr()") introduce a wrong logic when write val to >> LCR reg. When CONFIG_64BIT enabled,

Re: [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

2016-04-04 Thread Greg Kroah-Hartman
On Tue, Apr 05, 2016 at 11:32:46AM +0800, Kefeng Wang wrote: > Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate > with new dw8250_check_lcr()") introduce a wrong logic when write val to > LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally. > > The __raw

[PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

2016-04-04 Thread Kefeng Wang
Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()") introduce a wrong logic when write val to LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally. The __raw_readq/__raw_writeq is introduced by commit bca2092d7897 ("serial: 8250