Re: [PATCH v3] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.

2015-05-30 Thread Alexandre Belloni
On 28/05/2015 at 08:48:45 +0200, Jan Kardell wrote : > Return -EINVAL if the voltage low bit is set to avoid getting a bogus > time at boot. > There was a comment stating that util-linux hwclock refuses to set a > new time if we return an error code on read, but at least the current > version do se

[PATCH v3] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.

2015-05-27 Thread Jan Kardell
Return -EINVAL if the voltage low bit is set to avoid getting a bogus time at boot. There was a comment stating that util-linux hwclock refuses to set a new time if we return an error code on read, but at least the current version do set the time as expected. Remove the comment and the check for va