Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

2020-12-11 Thread Uwe Kleine-König
nsaenzjulie...@suse.de, > > f.faine...@gmail.com, r...@broadcom.com, s...@mess.org, > > sbran...@broadcom.com, bcm-kernel-feedback-l...@broadcom.com, > > linux-...@vger.kernel.org, linux-rpi-ker...@lists.infradead.org, > > linux-arm-ker...@lists.infradead.org, linux-kern

Aw: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

2020-12-11 Thread Lino Sanfilippo
n...@broadcom.com, bcm-kernel-feedback-l...@broadcom.com, > linux-...@vger.kernel.org, linux-rpi-ker...@lists.infradead.org, > linux-arm-ker...@lists.infradead.org, linux-kernel@vger.kernel.org > Betreff: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic > configurat

Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

2020-12-10 Thread Uwe Kleine-König
Hello, On Tue, Dec 08, 2020 at 11:01:45PM +0100, Lino Sanfilippo wrote: > Use the newer .apply function of pwm_ops instead of .config, .enable, > .disable and .set_polarity. This guarantees atomic changes of the pwm > controller configuration. It also reduces the size of the driver. > > Since now

Aw: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

2020-12-09 Thread Lino Sanfilippo
Hi Uwe > Hello Lino, > > On Tue, Dec 08, 2020 at 11:01:45PM +0100, Lino Sanfilippo wrote: > > Use the newer .apply function of pwm_ops instead of .config, .enable, > > .disable and .set_polarity. This guarantees atomic changes of the pwm > > controller configuration. It also reduces the size of th

Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

2020-12-08 Thread Uwe Kleine-König
Hello Lino, On Tue, Dec 08, 2020 at 11:01:45PM +0100, Lino Sanfilippo wrote: > Use the newer .apply function of pwm_ops instead of .config, .enable, > .disable and .set_polarity. This guarantees atomic changes of the pwm > controller configuration. It also reduces the size of the driver. > > Sinc

[PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

2020-12-08 Thread Lino Sanfilippo
Use the newer .apply function of pwm_ops instead of .config, .enable, .disable and .set_polarity. This guarantees atomic changes of the pwm controller configuration. It also reduces the size of the driver. Since now period is a 64 bit value, add an extra check to reject periods that exceed the pos