Re: [PATCH v3] powerpc: Rework iommu_table locks

2013-06-27 Thread Benjamin Herrenschmidt
On Thu, 2013-06-27 at 14:53 +1000, Alexey Kardashevskiy wrote: > > 2. remove locks from functions being called by VFIO. The whole table > is given to the user space so it is responsible now for races. Sure but you still need to be careful that userspace cannot cause things that crash the kernel.

[PATCH v3] powerpc: Rework iommu_table locks

2013-06-26 Thread Alexey Kardashevskiy
The locks in arch/powerpc/kernel/iommu.c were initally added to protect iommu_table::it_map so the patch just makes things consistent. Specifically, it does: 1. add missing locks for it_map access during iommu_take_ownership/ iommu_release_ownership execution where the entire it_map is marked bus