Re: [PATCH v3] perf stat: Fix wrong skipping for per-die aggregation

Hi Jiri, On 1/4/2021 6:15 PM, Jiri Olsa wrote: On Fri, Dec 25, 2020 at 09:04:09AM +0800, Jin Yao wrote: SNIP void update_stats(struct stats *stats, u64 val) @@ -275,16 +276,39 @@ void evlist__save_aggr_prev_raw_counts(struct evlist *evlist) static void zero_per_pkg(struct evsel *count

Re: [PATCH v3] perf stat: Fix wrong skipping for per-die aggregation

On Fri, Dec 25, 2020 at 09:04:09AM +0800, Jin Yao wrote: SNIP > void update_stats(struct stats *stats, u64 val) > @@ -275,16 +276,39 @@ void evlist__save_aggr_prev_raw_counts(struct evlist > *evlist) > > static void zero_per_pkg(struct evsel *counter) > { > - if (counter->per_pkg_mask)

[PATCH v3] perf stat: Fix wrong skipping for per-die aggregation

Uncore becomes die-scope on Xeon Cascade Lake-AP and perf has supported --per-die aggregation yet. One issue is found in check_per_pkg() for uncore events running on AP system. On cascade Lake-AP, we have: S0-D0 S0-D1 S1-D0 S1-D1 But in check_per_pkg(), S0-D1 and S1-D1 are skipped because the ma