Re: [PATCH v3] oom, oom_reaper: do not enqueue same task twice

2019-01-29 Thread Tetsuo Handa
Johannes Weiner wrote: > On Sun, Jan 27, 2019 at 11:57:38PM +0900, Tetsuo Handa wrote: > > This bug existed since the OOM reaper became invokable from > > task_will_free_mem(current) path in out_of_memory() in Linux 4.7, > > but memcg's group oom killing made it easier to trigger this bug by > > ca

Re: [PATCH v3] oom, oom_reaper: do not enqueue same task twice

2019-01-28 Thread Johannes Weiner
Hi Tetsuo, On Sun, Jan 27, 2019 at 11:57:38PM +0900, Tetsuo Handa wrote: > From 9c9e935fc038342c48461aabca666f1b544e32b1 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Sun, 27 Jan 2019 23:51:37 +0900 > Subject: [PATCH v3] oom, oom_reaper: do not enqueue same task twice &g

Re: [PATCH v3] oom, oom_reaper: do not enqueue same task twice

2019-01-28 Thread Michal Hocko
On Mon 28-01-19 10:15:13, Andrew Morton wrote: > On Sun, 27 Jan 2019 23:57:38 +0900 Tetsuo Handa > wrote: > > > Arkadiusz reported that enabling memcg's group oom killing causes > > strange memcg statistics where there is no task in a memcg despite > > the number of tasks in that memcg is not 0.

Re: [PATCH v3] oom, oom_reaper: do not enqueue same task twice

2019-01-28 Thread Andrew Morton
On Sun, 27 Jan 2019 23:57:38 +0900 Tetsuo Handa wrote: > Arkadiusz reported that enabling memcg's group oom killing causes > strange memcg statistics where there is no task in a memcg despite > the number of tasks in that memcg is not 0. It turned out that there > is a bug in wake_oom_reaper() w

Re: [PATCH v3] oom, oom_reaper: do not enqueue same task twice

2019-01-27 Thread Roman Gushchin
t; remove TIF_MEMDIE, and we can actually remove TIF_MEMDIE if you stop > whack-a-mole "can you observe it in real workload/program?" game. > I don't see a correctness issue with TIF_MEMDIE but I don't want to go > TIF_MEMDIE way. > > > > From 9c9e935fc038

Re: [PATCH v3] oom, oom_reaper: do not enqueue same task twice

2019-01-27 Thread Michal Hocko
On Sun 27-01-19 23:57:38, Tetsuo Handa wrote: [...] > >From 9c9e935fc038342c48461aabca666f1b544e32b1 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Sun, 27 Jan 2019 23:51:37 +0900 > Subject: [PATCH v3] oom, oom_reaper: do not enqueue same task twice > > Arkadiusz r

[PATCH v3] oom, oom_reaper: do not enqueue same task twice

2019-01-27 Thread Tetsuo Handa
want to remove TIF_MEMDIE, and we can actually remove TIF_MEMDIE if you stop whack-a-mole "can you observe it in real workload/program?" game. I don't see a correctness issue with TIF_MEMDIE but I don't want to go TIF_MEMDIE way. >From 9c9e935fc038342c48461aabca666f1b544e32b1 Mon Sep 17 00:00:00 2001 From: Tet