Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-26 Thread Ritesh Harjani
Hi Ulf, On 9/23/2016 3:37 PM, Ulf Hansson wrote: [...] Is there anything else needed in msm sdhci driver so that the auto tuning is taken care of? I am not familiar with any other than sdhci-esdhc-imx which supports the SDHCI_TUNING_MODE_3. I may be wrong though. In the sdhci-esdhc-imx ca

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-23 Thread Ulf Hansson
[...] Is there anything else needed in msm sdhci driver so that the auto tuning is taken care of? >>> >>> >>> I am not familiar with any other than sdhci-esdhc-imx which supports >>> the SDHCI_TUNING_MODE_3. I may be wrong though. >>> >>> In the sdhci-esdhc-imx case, enabling of auto tun

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-22 Thread Pramod Gurav
Hi Ritesh, Thanks for the inputs. On 22 September 2016 at 20:02, Ritesh Harjani wrote: > Hi Pramod, >> Thanks Ulf for the comments. Will check this and see if there is >> something of this sort we have to do to achieve auto tuning. >> Adding Ritesh who has been posting some SDHCI MSM patches

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-22 Thread Ritesh Harjani
Hi Pramod, On 9/15/2016 7:28 PM, Pramod Gurav wrote: On 15 September 2016 at 15:49, Ulf Hansson wrote: On 15 September 2016 at 09:59, Pramod Gurav wrote: On 9 September 2016 at 15:48, Georgi Djakov wrote: On 09/08/2016 11:02 AM, Adrian Hunter wrote: On 01/09/16 17:23, Pramod Gurav wrote:

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-15 Thread Pramod Gurav
On 15 September 2016 at 15:49, Ulf Hansson wrote: > On 15 September 2016 at 09:59, Pramod Gurav wrote: >> On 9 September 2016 at 15:48, Georgi Djakov wrote: >>> On 09/08/2016 11:02 AM, Adrian Hunter wrote: On 01/09/16 17:23, Pramod Gurav wrote: > > Provides runtime PM callbacks

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-15 Thread Ulf Hansson
On 15 September 2016 at 09:59, Pramod Gurav wrote: > On 9 September 2016 at 15:48, Georgi Djakov wrote: >> On 09/08/2016 11:02 AM, Adrian Hunter wrote: >>> >>> On 01/09/16 17:23, Pramod Gurav wrote: Provides runtime PM callbacks to enable and disable clock resources when idle. Also

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-15 Thread Pramod Gurav
On 9 September 2016 at 15:48, Georgi Djakov wrote: > On 09/08/2016 11:02 AM, Adrian Hunter wrote: >> >> On 01/09/16 17:23, Pramod Gurav wrote: >>> >>> Provides runtime PM callbacks to enable and disable clock resources >>> when idle. Also support system PM callbacks to be called during system >>>

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-12 Thread Pramod Gurav
On 9 September 2016 at 15:30, Tummala, Sahitya wrote: > Hi Pramod, >> + ret = clk_prepare_enable(msm_host->clk); >> + if (ret) { >> + dev_err(dev, "clk_enable failed: %d\n", ret); > > A minor comment - Both error prints related to clock enable are same. Better > to print

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-09 Thread Georgi Djakov
On 09/08/2016 11:02 AM, Adrian Hunter wrote: On 01/09/16 17:23, Pramod Gurav wrote: Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav Can we get some Teste

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-09 Thread Tummala, Sahitya
Hi Pramod, On 9/1/2016 7:53 PM, Pramod Gurav wrote: Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- Changes in v3: - Added CONFIG_PM around runtime pm

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-08 Thread Adrian Hunter
On 01/09/16 17:23, Pramod Gurav wrote: > Provides runtime PM callbacks to enable and disable clock resources > when idle. Also support system PM callbacks to be called during system > suspend and resume. > > Signed-off-by: Pramod Gurav Can we get some Tested/Reviewed/Acked-by from people using t

[PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- Changes in v3: - Added CONFIG_PM around runtime pm function. - Replaced msm suspend/resume with generic fu