RE: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-22 Thread Seungwon Jeon
On Friday, February 22, 2013, Dongjin Kim wrote: > Hello Seungwon, > > OK, I will change the commit message. And I also think Alim's idea is > good but need more detail about functional features of Synopsis' IP. Yes, Alim gave good suggestions. It would be useful. But I think it's close to platfo

Re: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-21 Thread Dongjin Kim
Hello Seungwon, OK, I will change the commit message. And I also think Alim's idea is good but need more detail about functional features of Synopsis' IP. Similar situation would be happened to Exynos4210 which is not supported by dw_mmc-exynos.c yet. Regards, Dongjin. On Thu, Feb 21, 2013 at 7:

RE: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-21 Thread Seungwon Jeon
On Wednesday, February 20, 2013, Alim Akhtar wrote: > Hi, > > On Tue, Feb 19, 2013 at 6:04 PM, Dongjin Kim wrote: > > Hello Seungwon, > > > > Thank you for reviewing and I understand what you mean. > > > > I agree that Exynos5250 and Exynos4412 are not same, no idea how much > > they are differen

Re: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-19 Thread Alim Akhtar
Hi, On Tue, Feb 19, 2013 at 6:04 PM, Dongjin Kim wrote: > Hello Seungwon, > > Thank you for reviewing and I understand what you mean. > > I agree that Exynos5250 and Exynos4412 are not same, no idea how much > they are different because no Exynos5250 spec on my hand. But at least > I assumed that

Re: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-19 Thread Dongjin Kim
Hello Seungwon, Thank you for reviewing and I understand what you mean. I agree that Exynos5250 and Exynos4412 are not same, no idea how much they are different because no Exynos5250 spec on my hand. But at least I assumed that the capabilities below are supported by Exynos4412 in terms of its da

RE: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-19 Thread Seungwon Jeon
On Tuesday, February 19, 2013, Dongjin Kim wrote: > This patch adds the compatible string for MSHC controller of Exynos4412, and > share the controller specific properties with Exynos5250 since they have same > features. Its driver data name is changed to exynos_drv_data instead SoC > specific name

Re: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-18 Thread Arnd Bergmann
On Monday 18 February 2013, Dongjin Kim wrote: > > This patch adds the compatible string for MSHC controller of Exynos4412, and > share the controller specific properties with Exynos5250 since they have same > features. Its driver data name is changed to exynos_drv_data instead SoC > specific name

[PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-18 Thread Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos_drv_data instead SoC specific name. Cc: Jaehoon Chung Cc: Sachin Kamat Signed-off-by: Don