Re: [PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Coly Li
On 2020/10/2 02:47, Vicente Bergas wrote: > On Thursday, October 1, 2020 9:18:24 AM CEST, Coly Li wrote: >> In mmc_queue_setup_discard() the mmc driver queue's discard_granularity >> might be set as 0 (when card->pref_erase > max_discard) while the mmc >> device still declares to support discard op

Re: [PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Vicente Bergas
On Thursday, October 1, 2020 9:18:24 AM CEST, Coly Li wrote: In mmc_queue_setup_discard() the mmc driver queue's discard_granularity might be set as 0 (when card->pref_erase > max_discard) while the mmc device still declares to support discard operation. This is buggy and triggered the following

Re: [PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Adrian Hunter
On 1/10/20 12:27 pm, Vicente Bergas wrote: > On Thu, Oct 1, 2020 at 11:07 AM Adrian Hunter wrote: >> >> On 1/10/20 11:38 am, Vicente Bergas wrote: >>> On Thu, Oct 1, 2020 at 9:18 AM Coly Li wrote: In mmc_queue_setup_discard() the mmc driver queue's discard_granularity might be set

Re: [PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Coly Li
On 2020/10/1 17:27, Vicente Bergas wrote: > On Thu, Oct 1, 2020 at 11:07 AM Adrian Hunter wrote: >> >> On 1/10/20 11:38 am, Vicente Bergas wrote: >>> On Thu, Oct 1, 2020 at 9:18 AM Coly Li wrote: In mmc_queue_setup_discard() the mmc driver queue's discard_granularity might be set a

Re: [PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Coly Li
On 2020/10/1 16:38, Vicente Bergas wrote: > On Thu, Oct 1, 2020 at 9:18 AM Coly Li wrote: >> >> In mmc_queue_setup_discard() the mmc driver queue's discard_granularity >> might be set as 0 (when card->pref_erase > max_discard) while the mmc >> device still declares to support discard operation. Th

Re: [PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Vicente Bergas
On Thu, Oct 1, 2020 at 11:07 AM Adrian Hunter wrote: > > On 1/10/20 11:38 am, Vicente Bergas wrote: > > On Thu, Oct 1, 2020 at 9:18 AM Coly Li wrote: > >> > >> In mmc_queue_setup_discard() the mmc driver queue's discard_granularity > >> might be set as 0 (when card->pref_erase > max_discard) whil

Re: [PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Adrian Hunter
On 1/10/20 11:38 am, Vicente Bergas wrote: > On Thu, Oct 1, 2020 at 9:18 AM Coly Li wrote: >> >> In mmc_queue_setup_discard() the mmc driver queue's discard_granularity >> might be set as 0 (when card->pref_erase > max_discard) while the mmc >> device still declares to support discard operation. T

Re: [PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Vicente Bergas
On Thu, Oct 1, 2020 at 9:18 AM Coly Li wrote: > > In mmc_queue_setup_discard() the mmc driver queue's discard_granularity > might be set as 0 (when card->pref_erase > max_discard) while the mmc > device still declares to support discard operation. This is buggy and > triggered the following kernel

[PATCH v3] mmc: core: don't set limits.discard_granularity as 0

2020-10-01 Thread Coly Li
In mmc_queue_setup_discard() the mmc driver queue's discard_granularity might be set as 0 (when card->pref_erase > max_discard) while the mmc device still declares to support discard operation. This is buggy and triggered the following kernel warning message, WARNING: CPU: 0 PID: 135 at __blkdev_i