Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-25 Thread Lee Jones
On Tue, 25 Apr 2017, 冯伟linux wrote: > Hi Lee Jones: > I send this email mainly for the fllowing two things; > 1.Is there anything unclear about the patch "mfd:rtsx: do retry when > dma transfer error" > 2.Whether the pach I submitted in email "[PATCH v4] mfd:rtsx: do > retry when DMA t

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-25 Thread 冯伟linux
Hi Lee Jones: I send this email mainly for the fllowing two things; 1.Is there anything unclear about the patch "mfd:rtsx: do retry when dma transfer error" 2.Whether the pach I submitted in email "[PATCH v4] mfd:rtsx: do retry when DMA transfer error" will be merged? steven fe

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-10 Thread 冯伟linux
> This errno need to be -EILSEQ. > You need to explain why. > When DMA transfer error with -EILSEQ, the request will retry some times, but when with errno -EINVAL, the request will be aborted directly. At the same time the DMA transfer error truely beacuse of the Illegal byte sequence, so -EILSEQ

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-10 Thread Lee Jones
On Mon, 10 Apr 2017, 冯伟linux wrote: > > --- a/drivers/mfd/rtsx_pcr.c > > +++ b/drivers/mfd/rtsx_pcr.c > > @@ -30,6 +30,7 @@ > > #include > > #include > > #include > > +#include > > Why is this required? > > > The UHS_SER104_MAX_DTR which is in "card_clock = UHS_SER104_MAX_DTR > - (pcr->dma

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-10 Thread 冯伟linux
> --- a/drivers/mfd/rtsx_pcr.c > +++ b/drivers/mfd/rtsx_pcr.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > Why is this required? > The UHS_SER104_MAX_DTR which is in "card_clock = UHS_SER104_MAX_DTR - (pcr->dma_error_count *2000)" is defined in linux/mmc/card.h, so

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-07 Thread Lee Jones
On Fri, 07 Apr 2017, 冯伟linux wrote: > HI lee.jones > > I submitted my patch a few months ago, but the patch was not merged. > I want to know what causes this, so that I can update the patch and make > the patch merged. The patch was missed. I do not know why. > steven feng > Realsil Micro

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-07 Thread 冯伟linux
HI lee.jones I submitted my patch a few months ago, but the patch was not merged. I want to know what causes this, so that I can update the patch and make the patch merged. steven feng Realsil Microelectronics CO. LTD. Mobile:181-6899-0403 Ext:57594 On 2017年01月05日 17:01, 冯伟linux wrote: >

[PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-01-05 Thread steven_feng
From: steven_feng the request should be reissued when dma transfer error. for rts5227, the clock freq need to step reduce when error occurred. Signed-off-by: steven_feng --- drivers/mfd/rtsx_pcr.c | 17 +++-- include/linux/mfd/rtsx_pci.h | 5 + 2 files changed, 20 insert