Re: [PATCH v3] mfd: MAX6650/6651 support

2014-02-10 Thread Lee Jones
> >> +static struct mfd_cell max665x_devs[] = { > >> + { .name = "max6651-gpio", }, > >> + { .name = "max6650", }, /* hwmon driver */ > > > > What happened to renaming the hwmon driver, so we can have > > "max6650-hwmon" here? > > I will add the alias in the next patch (e.g. hwmon change).

Re: [PATCH v3] mfd: MAX6650/6651 support

2014-02-10 Thread Laszlo Papp
>>> +}; >>> +MODULE_DEVICE_TABLE(i2c, max665x_id); >>> + >>> +static struct i2c_driver max665x_driver = { >>> + .driver = { >>> + .name = "max665x", >>> + .owner = THIS_MODULE, >> >> All new drivers are required to support Device Tree. > > Do you have some recommendation

Re: [PATCH v3] mfd: MAX6650/6651 support

2014-02-10 Thread Laszlo Papp
>> +static struct mfd_cell max665x_devs[] = { >> + { .name = "max6651-gpio", }, >> + { .name = "max6650", }, /* hwmon driver */ > > What happened to renaming the hwmon driver, so we can have > "max6650-hwmon" here? I will add the alias in the next patch (e.g. hwmon change). I can come back

Re: [PATCH v3] mfd: MAX6650/6651 support

2014-02-10 Thread Lee Jones
> MAX6650/MAX6651 chip is a multi-function device with I2C busses. The > chip includes fan-speed regulators and monitors, GPIO, and alarm. > > This patch is an initial release of a MAX6650/6651 MFD driver that > supports to enable the chip with its primary I2C bus that will connect > the hwmon, an

[PATCH v3] mfd: MAX6650/6651 support

2014-02-10 Thread Laszlo Papp
MAX6650/MAX6651 chip is a multi-function device with I2C busses. The chip includes fan-speed regulators and monitors, GPIO, and alarm. This patch is an initial release of a MAX6650/6651 MFD driver that supports to enable the chip with its primary I2C bus that will connect the hwmon, and then the g