Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-16 Thread chenridong
On 2025/1/15 2:42, Paul E. McKenney wrote: > On Tue, Jan 14, 2025 at 08:13:37PM +0800, Chen Ridong wrote: >> >> >> On 2025/1/14 17:20, Vlastimil Babka wrote: >>> On 1/14/25 09:40, Michal Hocko wrote: On Mon 13-01-25 19:45:46, Andrew Morton wrote: > On Mon, 13 Jan 2025 14:51:55 +0800 Che

Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-14 Thread Paul E. McKenney
On Tue, Jan 14, 2025 at 08:13:37PM +0800, Chen Ridong wrote: > > > On 2025/1/14 17:20, Vlastimil Babka wrote: > > On 1/14/25 09:40, Michal Hocko wrote: > >> On Mon 13-01-25 19:45:46, Andrew Morton wrote: > >>> On Mon, 13 Jan 2025 14:51:55 +0800 Chen Ridong > >>> wrote: > >>> > >> @@ -430,10

Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-14 Thread Chen Ridong
On 2025/1/14 17:30, Michal Hocko wrote: > On Tue 14-01-25 10:20:28, Vlastimil Babka wrote: >> On 1/14/25 09:40, Michal Hocko wrote: >>> On Mon 13-01-25 19:45:46, Andrew Morton wrote: > [...] > For global OOM, system is likely to struggle, do we have to do some > works to suppress RCU det

Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-14 Thread Chen Ridong
On 2025/1/14 17:20, Vlastimil Babka wrote: > On 1/14/25 09:40, Michal Hocko wrote: >> On Mon 13-01-25 19:45:46, Andrew Morton wrote: >>> On Mon, 13 Jan 2025 14:51:55 +0800 Chen Ridong >>> wrote: >>> >> @@ -430,10 +431,15 @@ static void dump_tasks(struct oom_control *oc) >>

Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-14 Thread Michal Hocko
On Tue 14-01-25 10:20:28, Vlastimil Babka wrote: > On 1/14/25 09:40, Michal Hocko wrote: > > On Mon 13-01-25 19:45:46, Andrew Morton wrote: [...] > >> > For global OOM, system is likely to struggle, do we have to do some > >> > works to suppress RCU detete? > >> > >> rcu_cpu_stall_reset()? > > >

Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-14 Thread Vlastimil Babka
On 1/14/25 09:40, Michal Hocko wrote: > On Mon 13-01-25 19:45:46, Andrew Morton wrote: >> On Mon, 13 Jan 2025 14:51:55 +0800 Chen Ridong >> wrote: >> >> > >> @@ -430,10 +431,15 @@ static void dump_tasks(struct oom_control *oc) >> > >> mem_cgroup_scan_tasks(oc->memcg, dump_task, o

Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-14 Thread Michal Hocko
On Mon 13-01-25 19:45:46, Andrew Morton wrote: > On Mon, 13 Jan 2025 14:51:55 +0800 Chen Ridong > wrote: > > > > > > > On 2025/1/6 16:45, Vlastimil Babka wrote: > > > On 12/24/24 03:52, Chen Ridong wrote: > > >> From: Chen Ridong > > > > > > +CC RCU > > > > > >> A soft lockup issue was foun

Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-13 Thread Andrew Morton
On Mon, 13 Jan 2025 14:51:55 +0800 Chen Ridong wrote: > > > On 2025/1/6 16:45, Vlastimil Babka wrote: > > On 12/24/24 03:52, Chen Ridong wrote: > >> From: Chen Ridong > > > > +CC RCU > > > >> A soft lockup issue was found in the product with about 56,000 tasks were > >> in the OOM cgroup, i

Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-12 Thread Chen Ridong
On 2025/1/6 16:45, Vlastimil Babka wrote: > On 12/24/24 03:52, Chen Ridong wrote: >> From: Chen Ridong > > +CC RCU > >> A soft lockup issue was found in the product with about 56,000 tasks were >> in the OOM cgroup, it was traversing them when the soft lockup was >> triggered. >> >> watchdog:

Re: [PATCH v3] memcg: fix soft lockup in the OOM process

2025-01-06 Thread Vlastimil Babka
On 12/24/24 03:52, Chen Ridong wrote: > From: Chen Ridong +CC RCU > A soft lockup issue was found in the product with about 56,000 tasks were > in the OOM cgroup, it was traversing them when the soft lockup was > triggered. > > watchdog: BUG: soft lockup - CPU#2 stuck for 23s! [VM Thread:150306