Re: [PATCH v3] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-10 Thread Josh Poimboeuf
On Tue, Nov 10, 2015 at 09:49:09AM +0100, Miroslav Benes wrote: > On Mon, 9 Nov 2015, Josh Poimboeuf wrote: > > > On Mon, Nov 09, 2015 at 05:01:18PM -0600, Chris J Arges wrote: > > > On 11/09/2015 02:56 PM, Josh Poimboeuf wrote: > > > > I'd recommend splitting this up into two separate patches: >

Re: [PATCH v3] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-10 Thread Miroslav Benes
On Mon, 9 Nov 2015, Chris J Arges wrote: > In cases of duplicate symbols in vmlinux, old_sympos will be used to > disambiguate instead of old_addr. Normally old_sympos will be 0, and > default to only returning the first found instance of that symbol. If an > incorrect symbol position is specified

Re: [PATCH v3] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-10 Thread Miroslav Benes
On Mon, 9 Nov 2015, Josh Poimboeuf wrote: > On Mon, Nov 09, 2015 at 05:01:18PM -0600, Chris J Arges wrote: > > On 11/09/2015 02:56 PM, Josh Poimboeuf wrote: > > > I'd recommend splitting this up into two separate patches: > > > > > > 1. introduce old_sympos > > > 2. change the sysfs interface > >

Re: [PATCH v3] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-09 Thread Josh Poimboeuf
On Mon, Nov 09, 2015 at 05:01:18PM -0600, Chris J Arges wrote: > On 11/09/2015 02:56 PM, Josh Poimboeuf wrote: > > I'd recommend splitting this up into two separate patches: > > > > 1. introduce old_sympos > > 2. change the sysfs interface > > > > On Mon, Nov 09, 2015 at 10:16:05AM -0600, Chris J

Re: [PATCH v3] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-09 Thread Chris J Arges
On 11/09/2015 02:56 PM, Josh Poimboeuf wrote: > I'd recommend splitting this up into two separate patches: > > 1. introduce old_sympos > 2. change the sysfs interface > > On Mon, Nov 09, 2015 at 10:16:05AM -0600, Chris J Arges wrote: >> In cases of duplicate symbols in vmlinux, old_sympos will be

Re: [PATCH v3] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-09 Thread Josh Poimboeuf
I'd recommend splitting this up into two separate patches: 1. introduce old_sympos 2. change the sysfs interface On Mon, Nov 09, 2015 at 10:16:05AM -0600, Chris J Arges wrote: > In cases of duplicate symbols in vmlinux, old_sympos will be used to > disambiguate instead of old_addr. Normally old_s

[PATCH v3] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-09 Thread Chris J Arges
In cases of duplicate symbols in vmlinux, old_sympos will be used to disambiguate instead of old_addr. Normally old_sympos will be 0, and default to only returning the first found instance of that symbol. If an incorrect symbol position is specified then livepatching will fail. Finally, old_addr is