Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-27 Thread Vijayanand Jitta
On 12/23/2020 8:10 PM, Alexander Potapenko wrote: >> >> Michan, We would still need config option so that we can reduce the >> memory consumption on low ram devices using config. >> >> Alex, On this, >> "I also suppose device vendors may prefer setting a fixed (maybe >> non-default) hash size fo

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-23 Thread Alexander Potapenko
> > Michan, We would still need config option so that we can reduce the > memory consumption on low ram devices using config. > > Alex, On this, > "I also suppose device vendors may prefer setting a fixed (maybe > non-default) hash size for low-memory devices rather than letting the > admins increa

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-21 Thread Vijayanand Jitta
On 12/22/2020 1:59 AM, Minchan Kim wrote: > On Mon, Dec 21, 2020 at 04:04:09PM +0100, Alexander Potapenko wrote: >> On Mon, Dec 21, 2020 at 12:15 PM Vijayanand Jitta >> wrote: >>> >>> >>> >>> On 12/18/2020 2:10 PM, Vijayanand Jitta wrote: On 12/17/2020 4:24 PM, Alexander Potapen

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-21 Thread Minchan Kim
On Mon, Dec 21, 2020 at 04:04:09PM +0100, Alexander Potapenko wrote: > On Mon, Dec 21, 2020 at 12:15 PM Vijayanand Jitta > wrote: > > > > > > > > On 12/18/2020 2:10 PM, Vijayanand Jitta wrote: > > > > > > > > > On 12/17/2020 4:24 PM, Alexander Potapenko wrote: > > Can you provide an example

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-21 Thread Alexander Potapenko
On Mon, Dec 21, 2020 at 12:15 PM Vijayanand Jitta wrote: > > > > On 12/18/2020 2:10 PM, Vijayanand Jitta wrote: > > > > > > On 12/17/2020 4:24 PM, Alexander Potapenko wrote: > Can you provide an example of a use case in which the user wants to > use the stack depot of a smaller size with

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-21 Thread Vijayanand Jitta
On 12/18/2020 2:10 PM, Vijayanand Jitta wrote: > > > On 12/17/2020 4:24 PM, Alexander Potapenko wrote: Can you provide an example of a use case in which the user wants to use the stack depot of a smaller size without disabling it completely, and that size cannot be configured st

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-18 Thread Vijayanand Jitta
On 12/17/2020 4:24 PM, Alexander Potapenko wrote: >>> Can you provide an example of a use case in which the user wants to >>> use the stack depot of a smaller size without disabling it completely, >>> and that size cannot be configured statically? >>> As far as I understand, for the page owner e

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-17 Thread Alexander Potapenko
> > Can you provide an example of a use case in which the user wants to > > use the stack depot of a smaller size without disabling it completely, > > and that size cannot be configured statically? > > As far as I understand, for the page owner example you gave it's > > sufficient to provide a swit

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-17 Thread Dmitry Vyukov
On Thu, Dec 17, 2020 at 11:25 AM Dmitry Vyukov wrote: > > On Thu, Dec 10, 2020 at 6:04 AM wrote: > > > > From: Yogesh Lal > > > > Add a kernel parameter stack_hash_order to configure STACK_HASH_SIZE. > > > > Aim is to have configurable value for STACK_HASH_SIZE, so that one > > can configure it

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-17 Thread Dmitry Vyukov
On Thu, Dec 10, 2020 at 6:04 AM wrote: > > From: Yogesh Lal > > Add a kernel parameter stack_hash_order to configure STACK_HASH_SIZE. > > Aim is to have configurable value for STACK_HASH_SIZE, so that one > can configure it depending on usecase there by reducing the static > memory overhead. > >

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-17 Thread Dmitry Vyukov
On Thu, Dec 17, 2020 at 6:42 AM Vijayanand Jitta wrote: > > On 12/16/2020 7:04 PM, Alexander Potapenko wrote: > >>> To reiterate, I think you don't need a tunable stack_hash_order > >>> parameter if the only use case is to disable the stack depot. > >>> Maybe it is enough to just add a boolean fla

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-16 Thread Vijayanand Jitta
On 12/16/2020 7:04 PM, Alexander Potapenko wrote: >>> To reiterate, I think you don't need a tunable stack_hash_order >>> parameter if the only use case is to disable the stack depot. >>> Maybe it is enough to just add a boolean flag? >> >> There are multiple users of stackdepot they might still

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-16 Thread Alexander Potapenko
> > To reiterate, I think you don't need a tunable stack_hash_order > > parameter if the only use case is to disable the stack depot. > > Maybe it is enough to just add a boolean flag? > > There are multiple users of stackdepot they might still want to use > stack depot but with a lower memory foot

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-16 Thread Vijayanand Jitta
On 12/16/2020 6:41 PM, Alexander Potapenko wrote: > On Wed, Dec 16, 2020 at 2:06 PM Vijayanand Jitta > wrote: >> >> >> >> On 12/16/2020 1:56 PM, Alexander Potapenko wrote: >>> On Wed, Dec 16, 2020 at 4:43 AM Vijayanand Jitta >>> wrote: On 12/14/2020 4:02 PM, Vijayanand Ji

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-16 Thread Alexander Potapenko
On Wed, Dec 16, 2020 at 2:06 PM Vijayanand Jitta wrote: > > > > On 12/16/2020 1:56 PM, Alexander Potapenko wrote: > > On Wed, Dec 16, 2020 at 4:43 AM Vijayanand Jitta > > wrote: > >> > >> > >> > >> On 12/14/2020 4:02 PM, Vijayanand Jitta wrote: > >>> > >>> > >>> On 12/14/2020 3:04 PM, Alexander

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-16 Thread Vijayanand Jitta
On 12/16/2020 1:56 PM, Alexander Potapenko wrote: > On Wed, Dec 16, 2020 at 4:43 AM Vijayanand Jitta > wrote: >> >> >> >> On 12/14/2020 4:02 PM, Vijayanand Jitta wrote: >>> >>> >>> On 12/14/2020 3:04 PM, Alexander Potapenko wrote: On Mon, Dec 14, 2020 at 5:02 AM Vijayanand Jitta wr

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-16 Thread Alexander Potapenko
On Wed, Dec 16, 2020 at 4:43 AM Vijayanand Jitta wrote: > > > > On 12/14/2020 4:02 PM, Vijayanand Jitta wrote: > > > > > > On 12/14/2020 3:04 PM, Alexander Potapenko wrote: > >> On Mon, Dec 14, 2020 at 5:02 AM Vijayanand Jitta > >> wrote: > >>> > >>> > >>> > >>> On 12/11/2020 6:55 PM, Alexander

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-15 Thread Vijayanand Jitta
On 12/14/2020 4:02 PM, Vijayanand Jitta wrote: > > > On 12/14/2020 3:04 PM, Alexander Potapenko wrote: >> On Mon, Dec 14, 2020 at 5:02 AM Vijayanand Jitta >> wrote: >>> >>> >>> >>> On 12/11/2020 6:55 PM, Alexander Potapenko wrote: On Fri, Dec 11, 2020 at 1:45 PM Vijayanand Jitta

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-14 Thread Vijayanand Jitta
On 12/14/2020 3:04 PM, Alexander Potapenko wrote: > On Mon, Dec 14, 2020 at 5:02 AM Vijayanand Jitta > wrote: >> >> >> >> On 12/11/2020 6:55 PM, Alexander Potapenko wrote: >>> On Fri, Dec 11, 2020 at 1:45 PM Vijayanand Jitta >>> wrote: On 12/11/2020 2:06 PM, Alexander Pot

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-14 Thread Alexander Potapenko
On Mon, Dec 14, 2020 at 5:02 AM Vijayanand Jitta wrote: > > > > On 12/11/2020 6:55 PM, Alexander Potapenko wrote: > > On Fri, Dec 11, 2020 at 1:45 PM Vijayanand Jitta > > wrote: > >> > >> > >> > >> On 12/11/2020 2:06 PM, Alexander Potapenko wrote: > >>> On Thu, Dec 10, 2020 at 6:01 AM wrote: >

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-13 Thread Vijayanand Jitta
On 12/11/2020 6:55 PM, Alexander Potapenko wrote: > On Fri, Dec 11, 2020 at 1:45 PM Vijayanand Jitta > wrote: >> >> >> >> On 12/11/2020 2:06 PM, Alexander Potapenko wrote: >>> On Thu, Dec 10, 2020 at 6:01 AM wrote: From: Yogesh Lal Add a kernel parameter stack_hash_order

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-11 Thread Alexander Potapenko
On Fri, Dec 11, 2020 at 1:45 PM Vijayanand Jitta wrote: > > > > On 12/11/2020 2:06 PM, Alexander Potapenko wrote: > > On Thu, Dec 10, 2020 at 6:01 AM wrote: > >> > >> From: Yogesh Lal > >> > >> Add a kernel parameter stack_hash_order to configure STACK_HASH_SIZE. > >> > >> Aim is to have configu

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-11 Thread Vijayanand Jitta
On 12/11/2020 2:06 PM, Alexander Potapenko wrote: > On Thu, Dec 10, 2020 at 6:01 AM wrote: >> >> From: Yogesh Lal >> >> Add a kernel parameter stack_hash_order to configure STACK_HASH_SIZE. >> >> Aim is to have configurable value for STACK_HASH_SIZE, so that one >> can configure it depending o

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-11 Thread Alexander Potapenko
On Thu, Dec 10, 2020 at 6:01 AM wrote: > > From: Yogesh Lal > > Add a kernel parameter stack_hash_order to configure STACK_HASH_SIZE. > > Aim is to have configurable value for STACK_HASH_SIZE, so that one > can configure it depending on usecase there by reducing the static > memory overhead. > >

[PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-09 Thread vjitta
From: Yogesh Lal Add a kernel parameter stack_hash_order to configure STACK_HASH_SIZE. Aim is to have configurable value for STACK_HASH_SIZE, so that one can configure it depending on usecase there by reducing the static memory overhead. One example is of Page Owner, default value of STACK_HASH