Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-04 Thread Andrey Ryabinin
On 07/04/2016 07:36 AM, Joonsoo Kim wrote: > On Fri, Jul 01, 2016 at 05:17:10PM +0300, Andrey Ryabinin wrote: >> >> >> On 07/01/2016 05:02 PM, js1...@gmail.com wrote: >>> From: Joonsoo Kim >>> >>> There are two bugs on qlist_move_cache(). One is that qlist's tail >>> isn't set properly. curr->ne

Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-03 Thread Joonsoo Kim
On Fri, Jul 01, 2016 at 05:17:10PM +0300, Andrey Ryabinin wrote: > > > On 07/01/2016 05:02 PM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > There are two bugs on qlist_move_cache(). One is that qlist's tail > > isn't set properly. curr->next can be NULL since it is singly linked > > li

Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-01 Thread Andrey Ryabinin
On 07/01/2016 05:15 PM, Dmitry Vyukov wrote: > On Fri, Jul 1, 2016 at 4:09 PM, Joonsoo Kim wrote: >> 2016-07-01 23:03 GMT+09:00 Dmitry Vyukov : + + if (obj_cache == cache) + qlist_put(to, qlink, cache->size); + else +

Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-01 Thread Joonsoo Kim
2016-07-01 23:20 GMT+09:00 Dmitry Vyukov : > On Fri, Jul 1, 2016 at 4:18 PM, Andrey Ryabinin > wrote: >> >> >> On 07/01/2016 05:15 PM, Dmitry Vyukov wrote: >>> On Fri, Jul 1, 2016 at 4:09 PM, Joonsoo Kim wrote: 2016-07-01 23:03 GMT+09:00 Dmitry Vyukov : >> >> + >> + if

Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-01 Thread Andrey Ryabinin
On 07/01/2016 05:02 PM, js1...@gmail.com wrote: > From: Joonsoo Kim > > There are two bugs on qlist_move_cache(). One is that qlist's tail > isn't set properly. curr->next can be NULL since it is singly linked > list and NULL value on tail is invalid if there is one item on qlist. > Another one

Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-01 Thread Dmitry Vyukov
On Fri, Jul 1, 2016 at 4:18 PM, Andrey Ryabinin wrote: > > > On 07/01/2016 05:15 PM, Dmitry Vyukov wrote: >> On Fri, Jul 1, 2016 at 4:09 PM, Joonsoo Kim wrote: >>> 2016-07-01 23:03 GMT+09:00 Dmitry Vyukov : > > + > + if (obj_cache == cache) > + qlis

Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-01 Thread Dmitry Vyukov
On Fri, Jul 1, 2016 at 4:09 PM, Joonsoo Kim wrote: > 2016-07-01 23:03 GMT+09:00 Dmitry Vyukov : >> On Fri, Jul 1, 2016 at 4:02 PM, wrote: >>> From: Joonsoo Kim >>> >>> There are two bugs on qlist_move_cache(). One is that qlist's tail >>> isn't set properly. curr->next can be NULL since it is s

Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-01 Thread Dmitry Vyukov
On Fri, Jul 1, 2016 at 4:02 PM, wrote: > From: Joonsoo Kim > > There are two bugs on qlist_move_cache(). One is that qlist's tail > isn't set properly. curr->next can be NULL since it is singly linked > list and NULL value on tail is invalid if there is one item on qlist. > Another one is that i

Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-01 Thread Joonsoo Kim
2016-07-01 23:03 GMT+09:00 Dmitry Vyukov : > On Fri, Jul 1, 2016 at 4:02 PM, wrote: >> From: Joonsoo Kim >> >> There are two bugs on qlist_move_cache(). One is that qlist's tail >> isn't set properly. curr->next can be NULL since it is singly linked >> list and NULL value on tail is invalid if t

[PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache()

2016-07-01 Thread js1304
From: Joonsoo Kim There are two bugs on qlist_move_cache(). One is that qlist's tail isn't set properly. curr->next can be NULL since it is singly linked list and NULL value on tail is invalid if there is one item on qlist. Another one is that if cache is matched, qlist_put() is called and it wil