Re: [PATCH v3] i2c: core-smbus: don't trace smbus_reply data on errors

2019-02-14 Thread Wolfram Sang
On Tue, Feb 12, 2019 at 07:40:57PM -0800, John Sperbeck wrote: > If an smbus transfer fails, there's no guarantee that the output > buffer was written. So, avoid trying to show the output buffer when > tracing after an error. This was 'mostly harmless', but would trip > up kasan checking if left-

Re: [PATCH v3] i2c: core-smbus: don't trace smbus_reply data on errors

2019-02-13 Thread Steven Rostedt
On Tue, 12 Feb 2019 19:40:57 -0800 John Sperbeck wrote: > If an smbus transfer fails, there's no guarantee that the output > buffer was written. So, avoid trying to show the output buffer when > tracing after an error. This was 'mostly harmless', but would trip > up kasan checking if left-over

[PATCH v3] i2c: core-smbus: don't trace smbus_reply data on errors

2019-02-12 Thread John Sperbeck
If an smbus transfer fails, there's no guarantee that the output buffer was written. So, avoid trying to show the output buffer when tracing after an error. This was 'mostly harmless', but would trip up kasan checking if left-over cruft in byte 0 is a large length, causing us to read from unwritt