> Ok then, Wolfram!
>
> Keep only:
>
> ereqirq:
> clk_disable_unprepare(i2c->clk);
>
> And let everyone else just return?
I haven't looked at the details, but when you simply can return, do it.
> It is rather pointless to add something in a patch, to remove it in the next.
Yup, just say
2014-07-04 19:24 GMT+02:00 Emil Goode :
> Hello,
>
> I noticed one more thing.
>
> On Fri, Jul 04, 2014 at 07:07:48PM +0200, Rickard Strandqvist wrote:
>> 2014-07-04 11:10 GMT+02:00 Emil Goode :
>> > Hello Rickard,
>> >
>> > Since this is a probe function there is also no need to release the devm_*
Hello,
I noticed one more thing.
On Fri, Jul 04, 2014 at 07:07:48PM +0200, Rickard Strandqvist wrote:
> 2014-07-04 11:10 GMT+02:00 Emil Goode :
> > Hello Rickard,
> >
> > Since this is a probe function there is also no need to release the devm_*
> > resources in the i2c_pxa_remove function, this
2014-07-04 11:10 GMT+02:00 Emil Goode :
> Hello Rickard,
>
> Since this is a probe function there is also no need to release the devm_*
> resources in the i2c_pxa_remove function, this leads to double free.
>
> Also I have a few nit-pick comments below.
>
> On Thu, Jul 03, 2014 at 10:19:16PM +0200,
Hello Rickard,
Since this is a probe function there is also no need to release the devm_*
resources in the i2c_pxa_remove function, this leads to double free.
Also I have a few nit-pick comments below.
On Thu, Jul 03, 2014 at 10:19:16PM +0200, Rickard Strandqvist wrote:
> Fix for possible null p
On Friday, July 04, 2014 5:19 AM, Rickard Strandqvist wrote:
>
> Fix for possible null pointer dereferenc, and there is a risk
> for memory leak if something unexpected
s/dereferenc/dereference
The columns of this commit is too long.
Please keep about 80 columns.
> happens and the function retu
After discussion with especially Wolfram and Jingoo it was decided to convert
the code to use the Managed Device Resource.
I lack this kind of hardware so preferably should someone do a HW test.
Rickard Strandqvist (1):
i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc
drivers
Fix for possible null pointer dereferenc, and there is a risk for memory leak
if something unexpected happens and the function returns.
It now use Managed Device Resource instead.
Signed-off-by: Rickard Strandqvist
---
drivers/i2c/busses/i2c-pxa.c | 37 -
1
8 matches
Mail list logo
