Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

2017-08-10 Thread Stefan Wahren
Hi Robin, Am 08.08.2017 um 20:03 schrieb Johan Hovold: > On Sat, Aug 05, 2017 at 10:38:07AM +0200, Christoph Hellwig wrote: >> I think the root problem is that the code added by >> " of/acpi: Configure dma operations at probe time for platform/amba/pci bus >> devices" >> >> is completely bogus and

Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

2017-08-08 Thread Johan Hovold
On Sat, Aug 05, 2017 at 10:38:07AM +0200, Christoph Hellwig wrote: > I think the root problem is that the code added by > " of/acpi: Configure dma operations at probe time for platform/amba/pci bus > devices" > > is completely bogus and needs to be reverted. We can't simply iterate > over all dev

Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

2017-08-05 Thread Christoph Hellwig
I think the root problem is that the code added by " of/acpi: Configure dma operations at probe time for platform/amba/pci bus devices" is completely bogus and needs to be reverted. We can't simply iterate over all devices in the system and set up dma for them. We'll need to ask the firmware / O

Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

2017-08-03 Thread Johan Hovold
On Thu, Aug 03, 2017 at 09:07:28AM -0700, Greg Kroah-Hartman wrote: > On Thu, Aug 03, 2017 at 05:52:08PM +0200, Johan Hovold wrote: > > USB devices use the DMA mask and offset of the controller, which have > > already been setup when a device is probed. Note that modifying the > > DMA mask of a USB

Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

2017-08-03 Thread Greg Kroah-Hartman
On Thu, Aug 03, 2017 at 05:52:08PM +0200, Johan Hovold wrote: > USB devices use the DMA mask and offset of the controller, which have > already been setup when a device is probed. Note that modifying the > DMA mask of a USB device would change the mask for the controller (and > all devices on the b

[PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

2017-08-03 Thread Johan Hovold
USB devices use the DMA mask and offset of the controller, which have already been setup when a device is probed. Note that modifying the DMA mask of a USB device would change the mask for the controller (and all devices on the bus) as the mask is literally shared. Since commit 2bf698671205 ("USB: