Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-24 Thread Darren Hart
On Tue, May 24, 2016 at 09:09:38AM +0200, Pali Rohár wrote: > On Tuesday 24 May 2016 06:48:41 Andrei Borzenkov wrote: > > 24.05.2016 02:03, Gabriele Mazzotta пишет: > > > On 24/05/2016 00:22, Pali Rohár wrote: ... > > > +#ifdef CONFIG_PM_SLEEP > > > +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-24 Thread Pali Rohár
On Tuesday 24 May 2016 06:48:41 Andrei Borzenkov wrote: > 24.05.2016 02:03, Gabriele Mazzotta пишет: > > On 24/05/2016 00:22, Pali Rohár wrote: > >> On Tuesday 24 May 2016 00:17:15 Darren Hart wrote: > >>> On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Rohár wrote: > On Monday 23 May 2016 23:2

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-23 Thread Andrei Borzenkov
24.05.2016 02:03, Gabriele Mazzotta пишет: > On 24/05/2016 00:22, Pali Rohár wrote: >> On Tuesday 24 May 2016 00:17:15 Darren Hart wrote: >>> On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Rohár wrote: On Monday 23 May 2016 23:26:55 Darren Hart wrote: > I've queued this. Thanks for your pa

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-23 Thread Gabriele Mazzotta
On 24/05/2016 00:22, Pali Rohár wrote: > On Tuesday 24 May 2016 00:17:15 Darren Hart wrote: >> On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Rohár wrote: >>> On Monday 23 May 2016 23:26:55 Darren Hart wrote: I've queued this. Thanks for your patience. >>> >>> Ok, In that case I would update c

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-23 Thread Pali Rohár
On Tuesday 24 May 2016 00:17:15 Darren Hart wrote: > On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Rohár wrote: > > On Monday 23 May 2016 23:26:55 Darren Hart wrote: > > > I've queued this. Thanks for your patience. > > > > Ok, In that case I would update comments in patch to try it more > > clea

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-23 Thread Darren Hart
On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Rohár wrote: > On Monday 23 May 2016 23:26:55 Darren Hart wrote: > > I've queued this. Thanks for your patience. > > Ok, In that case I would update comments in patch to try it more clear > what code is doing. I thought I had your approval on this o

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-23 Thread Pali Rohár
On Monday 23 May 2016 23:26:55 Darren Hart wrote: > I've queued this. Thanks for your patience. Ok, In that case I would update comments in patch to try it more clear what code is doing. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-23 Thread Darren Hart
On Thu, May 19, 2016 at 03:30:32PM +0200, Pali Rohár wrote: > On Monday 25 April 2016 22:06:11 Gabriele Mazzotta wrote: > > 2016-04-18 14:35 GMT+02:00 Pali Rohár : > > > On Tuesday 29 March 2016 15:11:35 Rafael J. Wysocki wrote: > > >> On Monday, March 28, 2016 10:33:09 AM Darren Hart wrote: > > >>

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-19 Thread Darren Hart
On Thu, May 19, 2016 at 03:30:32PM +0200, Pali Rohár wrote: > On Monday 25 April 2016 22:06:11 Gabriele Mazzotta wrote: > > 2016-04-18 14:35 GMT+02:00 Pali Rohár : > > > On Tuesday 29 March 2016 15:11:35 Rafael J. Wysocki wrote: > > >> On Monday, March 28, 2016 10:33:09 AM Darren Hart wrote: > > >>

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-19 Thread Pali Rohár
On Monday 25 April 2016 22:06:11 Gabriele Mazzotta wrote: > 2016-04-18 14:35 GMT+02:00 Pali Rohár : > > On Tuesday 29 March 2016 15:11:35 Rafael J. Wysocki wrote: > >> On Monday, March 28, 2016 10:33:09 AM Darren Hart wrote: > >> > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote:

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-04-25 Thread Gabriele Mazzotta
2016-04-18 14:35 GMT+02:00 Pali Rohár : > On Tuesday 29 March 2016 15:11:35 Rafael J. Wysocki wrote: >> On Monday, March 28, 2016 10:33:09 AM Darren Hart wrote: >> > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: >> > > 2016-03-24 10:39 GMT+01:00 Pali Rohár : >> > > > On Monday

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-04-18 Thread Pali Rohár
On Tuesday 29 March 2016 15:11:35 Rafael J. Wysocki wrote: > On Monday, March 28, 2016 10:33:09 AM Darren Hart wrote: > > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: > > > 2016-03-24 10:39 GMT+01:00 Pali Rohár : > > > > On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-29 Thread Rafael J. Wysocki
On Monday, March 28, 2016 10:33:09 AM Darren Hart wrote: > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: > > 2016-03-24 10:39 GMT+01:00 Pali Rohár : > > > On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote: > > >> 2016-03-21 13:17 GMT+01:00 Pali Rohár : > > >> > On Friday

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-29 Thread Gabriele Mazzotta
2016-03-29 7:24 GMT+02:00 Darren Hart : > > On Mon, Mar 28, 2016 at 09:41:09PM +0200, Gabriele Mazzotta wrote: > > 2016-03-28 20:56 GMT+02:00 Darren Hart : > > > On Mon, Mar 28, 2016 at 07:58:09PM +0200, Gabriele Mazzotta wrote: > > >> 2016-03-28 19:33 GMT+02:00 Darren Hart : > > >> > On Thu, Mar 2

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-28 Thread Darren Hart
On Mon, Mar 28, 2016 at 09:41:09PM +0200, Gabriele Mazzotta wrote: > 2016-03-28 20:56 GMT+02:00 Darren Hart : > > On Mon, Mar 28, 2016 at 07:58:09PM +0200, Gabriele Mazzotta wrote: > >> 2016-03-28 19:33 GMT+02:00 Darren Hart : > >> > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-28 Thread Gabriele Mazzotta
2016-03-28 20:56 GMT+02:00 Darren Hart : > On Mon, Mar 28, 2016 at 07:58:09PM +0200, Gabriele Mazzotta wrote: >> 2016-03-28 19:33 GMT+02:00 Darren Hart : >> > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: >> >> 2016-03-24 10:39 GMT+01:00 Pali Rohár : >> >> > On Monday 21 March

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-28 Thread Darren Hart
On Mon, Mar 28, 2016 at 07:58:09PM +0200, Gabriele Mazzotta wrote: > 2016-03-28 19:33 GMT+02:00 Darren Hart : > > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: > >> 2016-03-24 10:39 GMT+01:00 Pali Rohár : > >> > On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote: > >> >>

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-28 Thread Gabriele Mazzotta
2016-03-28 19:33 GMT+02:00 Darren Hart : > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: >> 2016-03-24 10:39 GMT+01:00 Pali Rohár : >> > On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote: >> >> 2016-03-21 13:17 GMT+01:00 Pali Rohár : >> >> > On Friday 18 March 2016 23:44

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-28 Thread Darren Hart
On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: > 2016-03-24 10:39 GMT+01:00 Pali Rohár : > > On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote: > >> 2016-03-21 13:17 GMT+01:00 Pali Rohár : > >> > On Friday 18 March 2016 23:44:23 Gabriele Mazzotta wrote: > >> >> +#ifdef CO

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-24 Thread Gabriele Mazzotta
2016-03-24 10:39 GMT+01:00 Pali Rohár : > On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote: >> 2016-03-21 13:17 GMT+01:00 Pali Rohár : >> > On Friday 18 March 2016 23:44:23 Gabriele Mazzotta wrote: >> >> +#ifdef CONFIG_PM_SLEEP >> >> +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_flag(void

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-24 Thread Pali Rohár
On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote: > 2016-03-21 13:17 GMT+01:00 Pali Rohár : > > On Friday 18 March 2016 23:44:23 Gabriele Mazzotta wrote: > >> +#ifdef CONFIG_PM_SLEEP > >> +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_flag(void *context) > >> +{ > >> + struct rbtn_data

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-21 Thread Gabriele Mazzotta
2016-03-21 13:17 GMT+01:00 Pali Rohár : > On Friday 18 March 2016 23:44:23 Gabriele Mazzotta wrote: >> +#ifdef CONFIG_PM_SLEEP >> +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_flag(void *context) >> +{ >> + struct rbtn_data *rbtn_data = context; >> + >> + rbtn_data->suspended = false; >> +

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-21 Thread Pali Rohár
On Friday 18 March 2016 23:44:23 Gabriele Mazzotta wrote: > +#ifdef CONFIG_PM_SLEEP > +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_flag(void *context) > +{ > + struct rbtn_data *rbtn_data = context; > + > + rbtn_data->suspended = false; > +} > + > +static int rbtn_suspend(struct device *d

[PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-18 Thread Gabriele Mazzotta
Some BIOSes unconditionally send an ACPI notification to RBTN when the system is resuming from suspend. This makes dell-rbtn send an input event to userspace as if a function key was pressed. Prevent this by ignoring all the notifications received while the device is suspended. Link: https://bugzi