Re: [PATCH v3] Coccinelle: semantic patch for missing put_device()

2019-02-13 Thread Julia Lawall
On Wed, 13 Feb 2019, Markus Elfring wrote: > > The of_find_device_by_node() takes a reference to the underlying device > > structure, we should release that reference. > > I have got another concern for further software development considerations. > > How do you think about to describe here if

Re: [PATCH v3] Coccinelle: semantic patch for missing put_device()

2019-02-13 Thread Markus Elfring
> The of_find_device_by_node() takes a reference to the underlying device > structure, we should release that reference. I have got another concern for further software development considerations. How do you think about to describe here if it can be determined by source code analysis that the des

Re: [PATCH v3] coccinelle: semantic patch for missing put_device()

2019-02-13 Thread Markus Elfring
> Reviewed-by: Markus Elfring I have got doubts that my code review comments qualify already for this tag. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1f947a7a011fcceb14cb912f5481a53b18f1879a#n565 > Cc: co...@systeme.li

[PATCH v3] coccinelle: semantic patch for missing put_device()

2019-02-12 Thread Wen Yang
The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. By using this semantic patch, we have found some object reference leaks, such as: commit 11907e9d3533 ("ASoC: fsl-asoc-card: fix object reference leaks in fsl_asoc_card_probe") commi