On 25/10/20 11:21 am, Lukas Bulwahn wrote:
> This is a nice idea as well. And I recommend to do this kind of research
> looking at checkpatch and clang-format; both will not be the 'final tools'
> but I think if you can identify a good mix and combination of those two
> tools, we will get a goo
On Sat, 24 Oct 2020, Joe Perches wrote:
> On Sun, 2020-10-25 at 06:51 +0100, Lukas Bulwahn wrote:
> > We can identify a set of rules and clear automatic fixes that
> > maintainers can simply run this script over the patches they pick
> > up when they pick them up.
>
> checkpatch --fix-inplace
On Sun, 2020-10-25 at 06:51 +0100, Lukas Bulwahn wrote:
> We can identify a set of rules and clear automatic fixes that
> maintainers can simply run this script over the patches they pick
> up when they pick them up.
checkpatch --fix-inplace does that now.
But realistically, this is more an inter
On Sat, 24 Oct 2020, Joe Perches wrote:
> On Sat, 2020-10-24 at 18:54 +0530, Aditya wrote:
> > > Would you like to work on
> > > further rules that can be improved with your evaluation approach?
> >
> > Yes, I would like work on further rules.
>
> Some generic ideas:
>
> How about working t
On 24/10/20 9:03 pm, Joe Perches wrote:
> On Sat, 2020-10-24 at 18:54 +0530, Aditya wrote:
>>> Would you like to work on
>>> further rules that can be improved with your evaluation approach?
>>
>> Yes, I would like work on further rules.
>
> Some generic ideas:
>
> How about working to reduce ru
On Sat, 2020-10-24 at 18:54 +0530, Aditya wrote:
> > Would you like to work on
> > further rules that can be improved with your evaluation approach?
>
> Yes, I would like work on further rules.
Some generic ideas:
How about working to reduce runtime and complexity by
making the rules extensible
On 24/10/20 12:36 am, Lukas Bulwahn wrote:
>
>
> On Fri, 23 Oct 2020, Aditya Srivastava wrote:
>
>> Presence of hexadecimal address or symbol results in false warning
>> message by checkpatch.pl.
>>
>
> I think this strategy now makes sense and has the right complexity for a
> good heuristics
On Fri, 2020-10-23 at 21:06 +0200, Lukas Bulwahn wrote:
> On Fri, 23 Oct 2020, Aditya Srivastava wrote:
> > A quick evaluation on v5.6..v5.8 showed that this fix reduces
> > REPEATED_WORD warnings from 2797 to 907.
> >
> > A quick manual check found all cases are related to hex output or
> > list
On Fri, 23 Oct 2020, Aditya Srivastava wrote:
> Presence of hexadecimal address or symbol results in false warning
> message by checkpatch.pl.
>
> For example, running checkpatch on commit b8ad540dd4e4 ("mptcp: fix
> memory leak in mptcp_subflow_create_socket()") results in warning:
>
> WARNI
Presence of hexadecimal address or symbol results in false warning
message by checkpatch.pl.
For example, running checkpatch on commit b8ad540dd4e4 ("mptcp: fix
memory leak in mptcp_subflow_create_socket()") results in warning:
WARNING:REPEATED_WORD: Possible repeated word: 'ff'
00 00 00 00 0
10 matches
Mail list logo