On 01-Mar-19 11:25 PM, Tokunori Ikegami wrote:
[...]
> In function do_write_buffer(), in the for loop, there is a
> case chip_ready() returns 1 while chip_good() returns 0, so
> it never break the loop.
> To fix this, chip_good() is enough and it should timeo
The "mtd: " prefix is still missing. Should be "mtd: cfi: ". If you
send a new version, please fix that.
Thanks,
Boris
On Tue, 26 Feb 2019 22:00:48 +0800
Liu Jian wrote:
> In function do_write_buffer(), in the for loop, there is a case
> chip_ready() returns 1 while chip_good() returns 0, so i
On Sat, 2 Mar 2019 01:59:41 +0900
"Tokunori Ikegami" wrote:
> > [...]
> > > In function do_write_buffer(), in the for loop, there is a
> > > case chip_ready() returns 1 while chip_good() returns 0, so
> > > it never break the loop.
> > > To fix this, chip_good() is enough and it
> [...]
> > In function do_write_buffer(), in the for loop, there is a case
> > chip_ready() returns 1 while chip_good() returns 0, so it never break
> > the loop.
> > To fix this, chip_good() is enough and it should timeout if it stay
> > bad for a while.
> >
> > Fixes:
kernel.org;
> ikeg...@allied-telesis.co.jp; rich...@nod.at;
> linux-kernel@vger.kernel.org; marek.va...@gmail.com;
> linux-...@lists.infradead.org; computersforpe...@gmail.com;
> dw...@infradead.org; 'liujian (CE)'; vigne...@ti.com
> Subject: Re: [PATCH v3] cfi: fix deadloop i
[...]
> In function do_write_buffer(), in the for loop, there is a case
> chip_ready() returns 1 while chip_good() returns 0, so it never break
> the loop.
> To fix this, chip_good() is enough and it should timeout if it stay
> bad for a while.
>
> Fixes: dfeae1073583("m
Hi Ikegami,
On Fri, 1 Mar 2019 23:51:16 +0900
"Tokunori Ikegami" wrote:
> > Except this version no longer does what Vignesh suggested. See how you
> > no longer test if chip_good() is true if time_after() returns true. So,
> > imagine the thread entering this function is preempted just after the
orpe...@gmail.com; bbrezil...@kernel.org;
> > marek.va...@gmail.com; rich...@nod.at; joakim.tjernl...@infinera.com;
> > ikeg...@allied-telesis.co.jp; keesc...@chromium.org; vigne...@ti.com
> > Cc: linux-...@lists.infradead.org; linux-kernel@vger.kernel.org
> > Subject: RE: [PATCH
nl...@infinera.com;
> ikeg...@allied-telesis.co.jp; keesc...@chromium.org; vigne...@ti.com
> Cc: linux-...@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer
>
>
>
> > -Original Message-
om; rich...@nod.at;
> joakim.tjernl...@infinera.com; ikeg...@allied-telesis.co.jp;
> keesc...@chromium.org; vigne...@ti.com
> Cc: linux-...@lists.infradead.org; liujia...@huawei.com;
> linux-kernel@vger.kernel.org
> Subject: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer
>
>
In function do_write_buffer(), in the for loop, there is a case
chip_ready() returns 1 while chip_good() returns 0, so it never
break the loop.
To fix this, chip_good() is enough and it should timeout if it stay
bad for a while.
Fixes: dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to che
11 matches
Mail list logo
