Re: [PATCH v3] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

2021-01-21 Thread Marc Kleine-Budde
On 1/22/21 4:01 AM, Su Yanjun wrote: > The sizeof(u32) is hardcoded. It's better to use the config value in > regmap. > > It increases the size of target object, but it's flexible when new mcp chip > need other val_bytes. > > Signed-off-by: Su Yanjun > --- > drivers/net/can/spi/mcp251xfd/mcp251

[PATCH v3] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

2021-01-21 Thread Su Yanjun
The sizeof(u32) is hardcoded. It's better to use the config value in regmap. It increases the size of target object, but it's flexible when new mcp chip need other val_bytes. Signed-off-by: Su Yanjun --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 9 ++--- 1 file changed, 6 insertions(