Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-07-02 Thread Xiang Zheng
On 2020/6/29 0:14, Bjorn Helgaas wrote: > On Sun, Jun 28, 2020 at 12:18:10PM +0800, Xiang Zheng wrote: >> On 2020/6/26 7:24, Bjorn Helgaas wrote: >>> On Wed, Jun 24, 2020 at 06:23:09PM -0500, Bjorn Helgaas wrote: On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: > 7ea7e98fd8d

Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-06-28 Thread Bjorn Helgaas
On Sun, Jun 28, 2020 at 12:18:10PM +0800, Xiang Zheng wrote: > On 2020/6/26 7:24, Bjorn Helgaas wrote: > > On Wed, Jun 24, 2020 at 06:23:09PM -0500, Bjorn Helgaas wrote: > >> On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: > >>> 7ea7e98fd8d0 ("PCI: Block on access to temporarily unavai

Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-06-27 Thread Xiang Zheng
On 2020/6/26 7:24, Bjorn Helgaas wrote: > On Wed, Jun 24, 2020 at 06:23:09PM -0500, Bjorn Helgaas wrote: >> On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: >>> 7ea7e98fd8d0 ("PCI: Block on access to temporarily unavailable pci >>> device") suggests that the "pci_lock" is sufficient,

Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-06-27 Thread Xiang Zheng
Hi Bjorn, Sorry for the late reply, I had Dragon Boat Festival these days. On 2020/6/25 7:23, Bjorn Helgaas wrote: > On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: >> 7ea7e98fd8d0 ("PCI: Block on access to temporarily unavailable pci >> device") suggests that the "pci_lock" is suffi

Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-06-25 Thread Bjorn Helgaas
On Wed, Jun 24, 2020 at 06:23:09PM -0500, Bjorn Helgaas wrote: > On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: > > 7ea7e98fd8d0 ("PCI: Block on access to temporarily unavailable pci > > device") suggests that the "pci_lock" is sufficient, and all the > > callers of pci_wait_cfg() are

Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-06-24 Thread Bjorn Helgaas
On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: > 7ea7e98fd8d0 ("PCI: Block on access to temporarily unavailable pci > device") suggests that the "pci_lock" is sufficient, and all the > callers of pci_wait_cfg() are wrapped with the "pci_lock". > > However, since the commit cdcb33f982

Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-06-24 Thread Bjorn Helgaas
[+cc Stephane] On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: > 7ea7e98fd8d0 ("PCI: Block on access to temporarily unavailable pci > device") suggests that the "pci_lock" is sufficient, and all the > callers of pci_wait_cfg() are wrapped with the "pci_lock". > > However, since the c