Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-30 Thread Arnd Bergmann
On Thursday 29 October 2015 20:01:51 Michael Welling wrote: > On Fri, Oct 30, 2015 at 09:39:05AM +0900, Mark Brown wrote: > > On Thu, Oct 29, 2015 at 03:23:31PM -0700, Dmitry Torokhov wrote: > > > > > However, you have regmap in the driver core already. Mark, is it > > > possible to have regmap AP

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Dmitry Torokhov
On Thu, Oct 29, 2015 at 09:08:45PM -0500, Michael Welling wrote: > Dmitry, > > On Thu, Oct 29, 2015 at 06:45:22PM -0700, Dmitry Torokhov wrote: > > Hi Michael, > > > > On Wed, Oct 28, 2015 at 07:12:34PM -0500, Michael Welling wrote: > > > Adds support for the i2c based tsc2004. > > > > > > Due t

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Michael Welling
Dmitry, On Thu, Oct 29, 2015 at 06:45:22PM -0700, Dmitry Torokhov wrote: > Hi Michael, > > On Wed, Oct 28, 2015 at 07:12:34PM -0500, Michael Welling wrote: > > Adds support for the i2c based tsc2004. > > > > Due to the overlapping functionality of the tsc2004 and tsc2005 > > the common code was

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Dmitry Torokhov
Hi Michael, On Wed, Oct 28, 2015 at 07:12:34PM -0500, Michael Welling wrote: > Adds support for the i2c based tsc2004. > > Due to the overlapping functionality of the tsc2004 and tsc2005 > the common code was moved to a core driver (tsc200x-core). > > Signed-off-by: Michael Welling In addition

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Michael Welling
On Fri, Oct 30, 2015 at 09:39:05AM +0900, Mark Brown wrote: > On Thu, Oct 29, 2015 at 03:23:31PM -0700, Dmitry Torokhov wrote: > > > However, you have regmap in the driver core already. Mark, is it > > possible to have regmap API also allow doing raw underlying protocol > > transfer so that consum

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Mark Brown
On Thu, Oct 29, 2015 at 03:23:31PM -0700, Dmitry Torokhov wrote: > However, you have regmap in the driver core already. Mark, is it > possible to have regmap API also allow doing raw underlying protocol > transfer so that consumers could issue command requests without needing > to know if they nee

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Dmitry Torokhov
On Thu, Oct 29, 2015 at 04:53:53PM -0500, Michael Welling wrote: > On Thu, Oct 29, 2015 at 10:46:20PM +0100, Arnd Bergmann wrote: > > On Thursday 29 October 2015 09:22:37 Michael Welling wrote: > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > >drivers/built-in.o: In functio

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Michael Welling
On Thu, Oct 29, 2015 at 10:46:20PM +0100, Arnd Bergmann wrote: > On Thursday 29 October 2015 09:22:37 Michael Welling wrote: > > > > > > All errors (new ones prefixed by >>): > > > > > >drivers/built-in.o: In function `tsc2005_cmd': > > > >> tsc200x-core.c:(.text+0x2ae07f): undefined referenc

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Arnd Bergmann
On Thursday 29 October 2015 09:22:37 Michael Welling wrote: > > > > All errors (new ones prefixed by >>): > > > >drivers/built-in.o: In function `tsc2005_cmd': > > >> tsc200x-core.c:(.text+0x2ae07f): undefined reference to > > >> `i2c_smbus_write_byte' > > Argh! > > How do I fix this one?

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Michael Welling
On Thu, Oct 29, 2015 at 03:25:34PM +0800, kbuild test robot wrote: > Hi Michael, > > [auto build test ERROR on input/next -- if it's inappropriate base, please > suggest rules for selecting the more suitable base] > > url: > https://github.com/0day-ci/linux/commits/Michael-Welling/Input-tsc2

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread kbuild test robot
Hi Michael, [auto build test ERROR on input/next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Michael-Welling/Input-tsc2005-Add-support-for-tsc2004/20151029-081504 config: x86_64-randconfig-s1-10291412

[PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-28 Thread Michael Welling
Adds support for the i2c based tsc2004. Due to the overlapping functionality of the tsc2004 and tsc2005 the common code was moved to a core driver (tsc200x-core). Signed-off-by: Michael Welling --- v3: Splits the tsc2004 and tsc2005 into separate drivers with with common routines in tsc200x-core