Re: [PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

2020-07-08 Thread Kai-Heng Feng
Hi, > On Jul 3, 2020, at 20:27, Hans de Goede wrote: > > Hi, > > On 7/1/20 8:46 AM, Kai-Heng Feng wrote: >>> On Jun 19, 2020, at 17:56, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 6/19/20 6:16 AM, Kai-Heng Feng wrote: Hi, > On Jun 18, 2020, at 23:28, Hans de Goede wrote: > >>>

Re: [PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

2020-07-03 Thread Hans de Goede
Hi, On 7/1/20 8:46 AM, Kai-Heng Feng wrote: On Jun 19, 2020, at 17:56, Hans de Goede wrote: Hi, On 6/19/20 6:16 AM, Kai-Heng Feng wrote: Hi, On Jun 18, 2020, at 23:28, Hans de Goede wrote: Hi, On 6/18/20 4:55 PM, Kai-Heng Feng wrote: Many laptops can be woken up from Suspend-to-Idle

Re: [PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

2020-06-30 Thread Kai-Heng Feng
> On Jun 19, 2020, at 17:56, Hans de Goede wrote: > > Hi, > > On 6/19/20 6:16 AM, Kai-Heng Feng wrote: >> Hi, >>> On Jun 18, 2020, at 23:28, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 6/18/20 4:55 PM, Kai-Heng Feng wrote: Many laptops can be woken up from Suspend-to-Idle by touchpad.

Re: [PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

2020-06-19 Thread Hans de Goede
Hi, On 6/19/20 6:16 AM, Kai-Heng Feng wrote: Hi, On Jun 18, 2020, at 23:28, Hans de Goede wrote: Hi, On 6/18/20 4:55 PM, Kai-Heng Feng wrote: Many laptops can be woken up from Suspend-to-Idle by touchpad. This is also the default behavior on other OSes. So let's enable the wakeup support i

Re: [PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

2020-06-18 Thread Kai-Heng Feng
Hi, > On Jun 18, 2020, at 23:28, Hans de Goede wrote: > > Hi, > > On 6/18/20 4:55 PM, Kai-Heng Feng wrote: >> Many laptops can be woken up from Suspend-to-Idle by touchpad. This is >> also the default behavior on other OSes. >> So let's enable the wakeup support if the system defaults to >> Sus

Re: [PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

2020-06-18 Thread Hans de Goede
Hi, On 6/18/20 4:55 PM, Kai-Heng Feng wrote: Many laptops can be woken up from Suspend-to-Idle by touchpad. This is also the default behavior on other OSes. So let's enable the wakeup support if the system defaults to Suspend-to-Idle. I have been debugging a spurious wakeup issue on an Asus T

[PATCH v3] HID: i2c-hid: Enable touchpad wakeup from Suspend-to-Idle

2020-06-18 Thread Kai-Heng Feng
Many laptops can be woken up from Suspend-to-Idle by touchpad. This is also the default behavior on other OSes. So let's enable the wakeup support if the system defaults to Suspend-to-Idle. Signed-off-by: Kai-Heng Feng --- v3: - Use device_init_wakeup(). - Wording change. v2: - Fix compile e