Re: [PATCH v3] HID: add vivaldi HID driver

2020-09-30 Thread Jiri Kosina
On Wed, 9 Sep 2020, Sean O'Brien wrote: > Add vivaldi HID driver. This driver allows us to read and report the top > row layout of keyboards which provide a vendor-defined (Google) HID > usage. > > Signed-off-by: Sean O'Brien Queued in hid.git#for-5.10/vivaldi. Thanks, -- Jiri Kosina SUSE Lab

Re: ping: [PATCH v3] HID: add vivaldi HID driver

2020-09-21 Thread Sean O'Brien
Friendly ping.

Re: [PATCH v3] HID: add vivaldi HID driver

2020-09-09 Thread Sean O'Brien
> if ((parser->global.usage_page << 16) != HID_UP_GOOGLEVENDOR) > return; I'm a bit worried about adding an early return, as it may cause issues if someone doesn't notice when adding another case. Looking at this again I can easily remove the second line break now that I've changed the group

Re: [PATCH v3] HID: add vivaldi HID driver

2020-09-09 Thread Joe Perches
On Wed, 2020-09-09 at 15:03 -0700, Sean O'Brien wrote: > Add vivaldi HID driver. This driver allows us to read and report the top > row layout of keyboards which provide a vendor-defined (Google) HID > usage. [] > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c [] > @@ -814,6 +814,13 @

[PATCH v3] HID: add vivaldi HID driver

2020-09-09 Thread Sean O'Brien
Add vivaldi HID driver. This driver allows us to read and report the top row layout of keyboards which provide a vendor-defined (Google) HID usage. Signed-off-by: Sean O'Brien --- drivers/hid/Kconfig | 9 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-core.c| 7 ++ drivers