Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-22 Thread Robert Munteanu
On Thu, 2018-03-22 at 09:17 +0100, Robert Munteanu wrote: > On Wed, 2018-03-21 at 17:51 +0100, Ondrej Zary wrote: > > On Wednesday 21 March 2018 11:43:31 Robert Munteanu wrote: > > > +#define USB_VENDOR_ID_MICRODIA 0x0c45 > > > +#define USB_DEVICE_ID_REDRAGON_ASURA0x760b > > > > Micro

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-22 Thread Robert Munteanu
On Thu, 2018-03-22 at 09:33 +0100, Benjamin Tissoires wrote: > On Wed, Mar 21, 2018 at 5:33 PM, Robert Munteanu > wrote: > > Hi Benjamin, > > > > On Wed, 2018-03-21 at 17:12 +0100, Benjamin Tissoires wrote: > > > Hi Robert, > > > > > > First, apologies for not answering to the RFC. I missed it a

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-22 Thread Benjamin Tissoires
On Wed, Mar 21, 2018 at 5:33 PM, Robert Munteanu wrote: > Hi Benjamin, > > On Wed, 2018-03-21 at 17:12 +0100, Benjamin Tissoires wrote: >> Hi Robert, >> >> First, apologies for not answering to the RFC. I missed it and it >> fell >> down in my INBOX. >> >> On Wed, Mar 21, 2018 at 11:43 AM, Robert

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-22 Thread Robert Munteanu
On Wed, 2018-03-21 at 17:51 +0100, Ondrej Zary wrote: > On Wednesday 21 March 2018 11:43:31 Robert Munteanu wrote: > > +#define USB_VENDOR_ID_MICRODIA 0x0c45 > > +#define USB_DEVICE_ID_REDRAGON_ASURA0x760b > > Microdia is most probably an incorrect name. The 0c45 id probably > belongs

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-21 Thread Ondrej Zary
On Wednesday 21 March 2018 11:43:31 Robert Munteanu wrote: > +#define USB_VENDOR_ID_MICRODIA 0x0c45 > +#define USB_DEVICE_ID_REDRAGON_ASURA0x760b Microdia is most probably an incorrect name. The 0c45 id probably belongs to "Sonix Technology Co., Ltd." -- Ondrej Zary

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-21 Thread Robert Munteanu
Hi Benjamin, On Wed, 2018-03-21 at 17:12 +0100, Benjamin Tissoires wrote: > Hi Robert, > > First, apologies for not answering to the RFC. I missed it and it > fell > down in my INBOX. > > On Wed, Mar 21, 2018 at 11:43 AM, Robert Munteanu > wrote: > > The microdia family of keyboards uses a non-

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-21 Thread Benjamin Tissoires
Hi Robert, First, apologies for not answering to the RFC. I missed it and it fell down in my INBOX. On Wed, Mar 21, 2018 at 11:43 AM, Robert Munteanu wrote: > The microdia family of keyboards uses a non-standard way of sending > modifier keys. > > The down event always sets the first bit to 0x04

[PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-21 Thread Robert Munteanu
The microdia family of keyboards uses a non-standard way of sending modifier keys. The down event always sets the first bit to 0x04 and the second keycode to a custom value For instance, left shift sends the following bits 04 02 00 00 00 00 00 00 while left control sends 04 01 00 00 00 00 0