RE: [PATCH v3] Fix endian issues and remove the board specific codes

2015-05-25 Thread Hn Chen
- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Saturday, May 23, 2015 7:37 AM To: Hn Chen Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] Fix endian issues and remove the board specific codes Hi Hn, On Thu, May 21, 2015 at 03:43:08PM

Re: [PATCH v3] Fix endian issues and remove the board specific codes

2015-05-22 Thread Dmitry Torokhov
Hi Hn, On Thu, May 21, 2015 at 03:43:08PM +0800, Hn Chen wrote: > Hi, Dmitry, > > Thanks for your comments. > Here are my replies for some comments. > > > + fw_id = ((fw_chunk_info.chunk_info.version_number >> 12) & 0xF); > > + chip_id = (((dev_wdt87xx->sys_param.fw_id) >> 12) & 0xF); > > +

RE: [PATCH v3] Fix endian issues and remove the board specific codes

2015-05-21 Thread Hn Chen
Hi, Dmitry, Thanks for your comments. Here are my replies for some comments. > + fw_id = ((fw_chunk_info.chunk_info.version_number >> 12) & 0xF); > + chip_id = (((dev_wdt87xx->sys_param.fw_id) >> 12) & 0xF); > + > + if (fw_id != chip_id) { > + wdt87xx_get_sysparam(client,

Re: [PATCH v3] Fix endian issues and remove the board specific codes

2015-05-20 Thread Dmitry Torokhov
Hi Hn, On Mon, May 11, 2015 at 01:11:39AM +0800, HungNien Chen wrote: > Signed-off-by: HungNien Chen Thank you for making the requested changes. Some more comments below. > --- > drivers/input/touchscreen/Kconfig | 12 + > drivers/input/touchscreen/Makefile |1 + > drivers/inp

[PATCH v3] Fix endian issues and remove the board specific codes

2015-05-10 Thread HungNien Chen
Signed-off-by: HungNien Chen --- drivers/input/touchscreen/Kconfig | 12 + drivers/input/touchscreen/Makefile |1 + drivers/input/touchscreen/wdt87xx_i2c.c | 1509 +++ 3 files changed, 1522 insertions(+) create mode 100644 drivers/input/touchscreen/wd