Re: [PATCH v2 bpf-next 12/13] bpf: Add tests for new BPF atomic operations

2020-12-02 Thread Brendan Jackman
On Tue, Dec 01, 2020 at 06:22:50PM -0800, Andrii Nakryiko wrote: > On Fri, Nov 27, 2020 at 10:01 AM Brendan Jackman wrote: [...] > > + > > +static void test_xchg(void) > > +{ > > + struct atomics_test *atomics_skel = NULL; > > nit: = NULL is unnecessary [...[ > > + CHECK(atomics_skel-

Re: [PATCH v2 bpf-next 12/13] bpf: Add tests for new BPF atomic operations

2020-12-01 Thread Andrii Nakryiko
On Fri, Nov 27, 2020 at 10:01 AM Brendan Jackman wrote: > > This relies on the work done by Yonghong Song in > https://reviews.llvm.org/D72184 > > Note the hackery in the Makefile that is necessary to avoid breaking > tests for people who haven't yet got a version of Clang supporting > V4. It seem

Re: [PATCH v2 bpf-next 12/13] bpf: Add tests for new BPF atomic operations

2020-12-01 Thread Yonghong Song
On 12/1/20 4:56 AM, Brendan Jackman wrote: On Mon, Nov 30, 2020 at 07:55:02PM -0800, Yonghong Song wrote: On 11/27/20 9:57 AM, Brendan Jackman wrote: [...] diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index 3d5940cd110d..5eadfd09037d 100644 --- a

Re: [PATCH v2 bpf-next 12/13] bpf: Add tests for new BPF atomic operations

2020-12-01 Thread Brendan Jackman
On Mon, Nov 30, 2020 at 07:55:02PM -0800, Yonghong Song wrote: > On 11/27/20 9:57 AM, Brendan Jackman wrote: [...] > > diff --git a/tools/testing/selftests/bpf/Makefile > > b/tools/testing/selftests/bpf/Makefile > > index 3d5940cd110d..5eadfd09037d 100644 > > --- a/tools/testing/selftests/bpf/Make

Re: [PATCH v2 bpf-next 12/13] bpf: Add tests for new BPF atomic operations

2020-11-30 Thread Yonghong Song
On 11/27/20 9:57 AM, Brendan Jackman wrote: This relies on the work done by Yonghong Song in https://reviews.llvm.org/D72184 Note the hackery in the Makefile that is necessary to avoid breaking tests for people who haven't yet got a version of Clang supporting V4. It seems like this hackery o

[PATCH v2 bpf-next 12/13] bpf: Add tests for new BPF atomic operations

2020-11-27 Thread Brendan Jackman
This relies on the work done by Yonghong Song in https://reviews.llvm.org/D72184 Note the hackery in the Makefile that is necessary to avoid breaking tests for people who haven't yet got a version of Clang supporting V4. It seems like this hackery ought to be confined to tools/build/feature - I tr