Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-12-02 Thread Yonghong Song
On 12/1/20 9:05 PM, Yonghong Song wrote: On 12/1/20 6:00 PM, Andrii Nakryiko wrote: On Mon, Nov 30, 2020 at 7:51 PM Yonghong Song wrote: On 11/30/20 9:22 AM, Yonghong Song wrote: On 11/28/20 5:40 PM, Alexei Starovoitov wrote: On Fri, Nov 27, 2020 at 09:53:05PM -0800, Yonghong Song

Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-12-01 Thread John Fastabend
Andrii Nakryiko wrote: > On Tue, Dec 1, 2020 at 9:53 PM John Fastabend > wrote: > > > > Yonghong Song wrote: > > > > > > > > > > [...] > > > > > > Great, this means that all existing valid uses of > > > > __sync_fetch_and_add() will generate BPF_XADD instructions and will > > > > work on old kern

Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-12-01 Thread Andrii Nakryiko
On Tue, Dec 1, 2020 at 9:53 PM John Fastabend wrote: > > Yonghong Song wrote: > > > > > > [...] > > > > Great, this means that all existing valid uses of > > > __sync_fetch_and_add() will generate BPF_XADD instructions and will > > > work on old kernels, right? > > > > That is correct. > > > > > >

Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-12-01 Thread John Fastabend
Yonghong Song wrote: > > [...] > > Great, this means that all existing valid uses of > > __sync_fetch_and_add() will generate BPF_XADD instructions and will > > work on old kernels, right? > > That is correct. > > > > > If that's the case, do we still need cpu=v4? The new instructions are >

Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-12-01 Thread Yonghong Song
On 12/1/20 6:00 PM, Andrii Nakryiko wrote: On Mon, Nov 30, 2020 at 7:51 PM Yonghong Song wrote: On 11/30/20 9:22 AM, Yonghong Song wrote: On 11/28/20 5:40 PM, Alexei Starovoitov wrote: On Fri, Nov 27, 2020 at 09:53:05PM -0800, Yonghong Song wrote: On 11/27/20 9:57 AM, Brendan Jackm

Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-12-01 Thread Andrii Nakryiko
On Mon, Nov 30, 2020 at 7:51 PM Yonghong Song wrote: > > > > On 11/30/20 9:22 AM, Yonghong Song wrote: > > > > > > On 11/28/20 5:40 PM, Alexei Starovoitov wrote: > >> On Fri, Nov 27, 2020 at 09:53:05PM -0800, Yonghong Song wrote: > >>> > >>> > >>> On 11/27/20 9:57 AM, Brendan Jackman wrote: >

Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-11-30 Thread Yonghong Song
On 11/30/20 9:22 AM, Yonghong Song wrote: On 11/28/20 5:40 PM, Alexei Starovoitov wrote: On Fri, Nov 27, 2020 at 09:53:05PM -0800, Yonghong Song wrote: On 11/27/20 9:57 AM, Brendan Jackman wrote: Status of the patches = Thanks for the reviews! Differences from v1->v

Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-11-30 Thread Yonghong Song
On 11/28/20 5:40 PM, Alexei Starovoitov wrote: On Fri, Nov 27, 2020 at 09:53:05PM -0800, Yonghong Song wrote: On 11/27/20 9:57 AM, Brendan Jackman wrote: Status of the patches = Thanks for the reviews! Differences from v1->v2 [1]: * Fixed mistakes in the netronome dri

Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-11-28 Thread Alexei Starovoitov
On Fri, Nov 27, 2020 at 09:53:05PM -0800, Yonghong Song wrote: > > > On 11/27/20 9:57 AM, Brendan Jackman wrote: > > Status of the patches > > = > > > > Thanks for the reviews! Differences from v1->v2 [1]: > > > > * Fixed mistakes in the netronome driver > > > > * Addd sub,

Re: [PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-11-28 Thread Yonghong Song
On 11/27/20 9:57 AM, Brendan Jackman wrote: Status of the patches = Thanks for the reviews! Differences from v1->v2 [1]: * Fixed mistakes in the netronome driver * Addd sub, add, or, xor operations * The above led to some refactors to keep things readable. (Maybe I s

[PATCH v2 bpf-next 00/13] Atomics for eBPF

2020-11-27 Thread Brendan Jackman
Status of the patches = Thanks for the reviews! Differences from v1->v2 [1]: * Fixed mistakes in the netronome driver * Addd sub, add, or, xor operations * The above led to some refactors to keep things readable. (Maybe I should have just waited until I'd implemented these