Re: [PATCH v2 7/7] compiler-gcc: improve version error

2020-09-01 Thread Miguel Ojeda
On Tue, Sep 1, 2020 at 2:23 AM Nick Desaulniers wrote: > > do so provides developers "doing so"? "to do so"? > include/linux/compiler-gcc.h | 2 +- Reviewed-by: Miguel Ojeda Cheers, Miguel

Re: [PATCH v2 7/7] compiler-gcc: improve version error

2020-08-31 Thread Nathan Chancellor
On Mon, Aug 31, 2020 at 05:23:26PM -0700, Nick Desaulniers wrote: > As Kees suggests, do so provides developers with two useful pieces of > information: > - The kernel build was attempting to use GCC. > (Maybe they accidentally poked the wrong configs in a CI.) > - They need 4.9 or better. > ("

[PATCH v2 7/7] compiler-gcc: improve version error

2020-08-31 Thread Nick Desaulniers
As Kees suggests, do so provides developers with two useful pieces of information: - The kernel build was attempting to use GCC. (Maybe they accidentally poked the wrong configs in a CI.) - They need 4.9 or better. ("Upgrade to what version?" doesn't need to be dug out of documentation, head