Re: [PATCH v2 6/8] PCI: al: Add support for DW based driver type

2019-07-22 Thread Bjorn Helgaas
On Sun, Jul 21, 2019 at 03:08:18PM +, Chocron, Jonathan wrote: > On Fri, 2019-07-19 at 08:55 +, Gustavo Pimentel wrote: > > On Thu, Jul 18, 2019 at 10:47:16, Jonathan Chocron > > wrote: > > > +static int al_pcie_probe(struct platform_device *pdev) > > > +{ > > > + struct device *dev = &p

Re: [PATCH v2 6/8] PCI: al: Add support for DW based driver type

2019-07-22 Thread Chocron, Jonathan
On Mon, 2019-07-22 at 08:54 +, Gustavo Pimentel wrote: > > > > > > > +static inline void al_pcie_target_bus_set(struct al_pcie > > > > *pcie, > > > > + u8 target_bus, > > > > + u8 mask_target_bus) > > > > +{ > > >

RE: [PATCH v2 6/8] PCI: al: Add support for DW based driver type

2019-07-22 Thread Gustavo Pimentel
On Sun, Jul 21, 2019 at 16:8:18, Chocron, Jonathan wrote: > On Fri, 2019-07-19 at 08:55 +, Gustavo Pimentel wrote: > > On Thu, Jul 18, 2019 at 10:47:16, Jonathan Chocron > > > > wrote: > > > > > This driver is DT based and utilizes the DesignWare APIs. > > > It allows using a smaller ECAM

Re: [PATCH v2 6/8] PCI: al: Add support for DW based driver type

2019-07-21 Thread Benjamin Herrenschmidt
On Sun, 2019-07-21 at 15:08 +, Chocron, Jonathan wrote: > > Please sort the variables following the reverse tree order. > > > > Done. > > I'd think that it would make sense to group variables which have a > common characteristic (e.g. resources read from the DT), even if it > mildly breaks

Re: [PATCH v2 6/8] PCI: al: Add support for DW based driver type

2019-07-21 Thread Chocron, Jonathan
On Fri, 2019-07-19 at 08:55 +, Gustavo Pimentel wrote: > On Thu, Jul 18, 2019 at 10:47:16, Jonathan Chocron > > wrote: > > > This driver is DT based and utilizes the DesignWare APIs. > > It allows using a smaller ECAM range for a larger bus range - > > usually an entire bus uses 1MB of addre

RE: [PATCH v2 6/8] PCI: al: Add support for DW based driver type

2019-07-19 Thread Gustavo Pimentel
On Thu, Jul 18, 2019 at 10:47:16, Jonathan Chocron wrote: > This driver is DT based and utilizes the DesignWare APIs. > It allows using a smaller ECAM range for a larger bus range - > usually an entire bus uses 1MB of address space, but the driver > can use it for a larger number of buses. > >

[PATCH v2 6/8] PCI: al: Add support for DW based driver type

2019-07-18 Thread Jonathan Chocron
This driver is DT based and utilizes the DesignWare APIs. It allows using a smaller ECAM range for a larger bus range - usually an entire bus uses 1MB of address space, but the driver can use it for a larger number of buses. All link initializations are handled by the boot FW. Signed-off-by: Jona