Re: [alsa-devel] [linux-sunxi] Re: [PATCH v2 6/6] ASoC: sun4i-i2s: Add support for loopback

2018-03-13 Thread Mark Brown
On Tue, Mar 13, 2018 at 01:39:44PM +, Chris Obbard wrote: > >> +- loopback: if this property is present then the dai is configured in > >> + loopback mode where the output fifo is redirected to the > >> input > >> + fifo. > > This really doesn't seem like something th

Re: [linux-sunxi] Re: [PATCH v2 6/6] ASoC: sun4i-i2s: Add support for loopback

2018-03-13 Thread Chris Obbard
Hi Mark, > >> +- loopback: if this property is present then the dai is configured in >> + loopback mode where the output fifo is redirected to the input >> + fifo. > > This really doesn't seem like something that ought to go into the DT > and hence ABI given that there's o

Re: [linux-sunxi] Re: [PATCH v2 6/6] ASoC: sun4i-i2s: Add support for loopback

2018-03-13 Thread Maxime Ripard
On Tue, Mar 13, 2018 at 01:39:44PM +, Chris Obbard wrote: > >> +- loopback: if this property is present then the dai is configured in > >> + loopback mode where the output fifo is redirected to the > >> input > >> + fifo. > > > > This really doesn't seem like something

Re: [PATCH v2 6/6] ASoC: sun4i-i2s: Add support for loopback

2018-03-12 Thread Mark Brown
On Mon, Mar 12, 2018 at 04:57:53PM +0100, codekip...@gmail.com wrote: > +- loopback: if this property is present then the dai is configured in > + loopback mode where the output fifo is redirected to the input > + fifo. This really doesn't seem like something that ought t

[PATCH v2 6/6] ASoC: sun4i-i2s: Add support for loopback

2018-03-12 Thread codekipper
From: Marcus Cooper The DAI has a loopback register which can be set and therefore routes the transmit fifo to receive fifo. This is useful for testing the block without the need for any external hardware. Signed-off-by: Marcus Cooper --- Documentation/devicetree/bindings/sound/sun4i-i2s.txt |