Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects number

2021-03-01 Thread Marc Kleine-Budde
On 28.02.2021 11:18:13, Dario Binacchi wrote: > > > + u32 msg_obj_rx_mask; > > > > Is this variable big enough after you've extended the driver to use 64 > > mailboxes? > > Yes. I have kept the message assignment policy unchanged, they are equally > divided between reception and transmission. Th

Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects number

2021-02-28 Thread Dario Binacchi
Hi Marc, > Il 26/02/2021 09:33 Marc Kleine-Budde ha scritto: > > > On 25.02.2021 22:51:54, Dario Binacchi wrote: > > As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") > > the "driver casts the 16 message objects in stone, which is completely > > braindead as contemporary

Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects number

2021-02-26 Thread Marc Kleine-Budde
On 25.02.2021 22:51:54, Dario Binacchi wrote: > --- a/drivers/net/can/c_can/c_can.c > +++ b/drivers/net/can/c_can/c_can.c [...] > -struct net_device *alloc_c_can_dev(void) > +struct net_device *alloc_c_can_dev(int msg_obj_num) > { > struct net_device *dev; > struct c_can_priv *priv; >

Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects number

2021-02-26 Thread Marc Kleine-Budde
On 25.02.2021 22:51:54, Dario Binacchi wrote: > As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") > the "driver casts the 16 message objects in stone, which is completely > braindead as contemporary hardware has up to 128 message objects". > > The patch prepares the module t

[PATCH v2 5/6] can: c_can: prepare to up the message objects number

2021-02-25 Thread Dario Binacchi
As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") the "driver casts the 16 message objects in stone, which is completely braindead as contemporary hardware has up to 128 message objects". The patch prepares the module to extend the number of message objects beyond the 32 cur