Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

2017-12-18 Thread Leon Romanovsky
On Mon, Dec 18, 2017 at 11:03:51AM -0800, Joe Perches wrote: > On Mon, 2017-12-18 at 13:36 +0100, Knut Omang wrote: > > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > [] > > > Also, I agree with other reviewers, there is no excuse for adding > > > checkpatch specifics per-subsystem/fol

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

2017-12-18 Thread Joe Perches
On Mon, 2017-12-18 at 13:36 +0100, Knut Omang wrote: > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: [] > > Also, I agree with other reviewers, there is no excuse for adding > > checkpatch specifics per-subsystem/folder, the differences are better > > to be treated in checkpatch.pl itse

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

2017-12-18 Thread Knut Omang
On Mon, 2017-12-18 at 16:04 +0200, Leon Romanovsky wrote: > On Mon, Dec 18, 2017 at 01:36:26PM +0100, Knut Omang wrote: > > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > > > On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > > > > Add a runchecks.cfg to drivers/infiniband/c

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

2017-12-18 Thread Leon Romanovsky
On Mon, Dec 18, 2017 at 01:36:26PM +0100, Knut Omang wrote: > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > > On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > > > Add a runchecks.cfg to drivers/infiniband/core > > > to start "reining in" future checker errors, > > > and m

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

2017-12-18 Thread Knut Omang
On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > > Add a runchecks.cfg to drivers/infiniband/core > > to start "reining in" future checker errors, > > and making it easier to selectively clean up existing > > issues. > > > >

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

2017-12-18 Thread Leon Romanovsky
On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > Add a runchecks.cfg to drivers/infiniband/core > to start "reining in" future checker errors, > and making it easier to selectively clean up existing > issues. > > This runchecks.cfg lets make C=2 M=drivers/infiniband/core > pass with al

[PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

2017-12-16 Thread Knut Omang
Add a runchecks.cfg to drivers/infiniband/core to start "reining in" future checker errors, and making it easier to selectively clean up existing issues. This runchecks.cfg lets make C=2 M=drivers/infiniband/core pass with all errors/warnings suppressed See Documentation/dev-tools/runchecks.rst f