Re: [PATCH v2 4/7] fsnotify: skip unattached marks

2017-10-30 Thread Miklos Szeredi
On Mon, Oct 30, 2017 at 3:00 PM, Jan Kara wrote: > On Wed 25-10-17 10:41:36, Miklos Szeredi wrote: >> After having gone through a ref-unref for the mark, dereferencing the group >> (e.g. in fsnotify_compare_groups()) is wrong since the group may be >> completely gone by that time. So before conti

Re: [PATCH v2 4/7] fsnotify: skip unattached marks

2017-10-30 Thread Jan Kara
On Wed 25-10-17 10:41:36, Miklos Szeredi wrote: > After having gone through a ref-unref for the mark, dereferencing the group > (e.g. in fsnotify_compare_groups()) is wrong since the group may be > completely gone by that time. So before continuing to traverse the mark > list, check if the mark is

[PATCH v2 4/7] fsnotify: skip unattached marks

2017-10-25 Thread Miklos Szeredi
After having gone through a ref-unref for the mark, dereferencing the group (e.g. in fsnotify_compare_groups()) is wrong since the group may be completely gone by that time. So before continuing to traverse the mark list, check if the mark is still attached. This is done in the generic case, not