Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-20 Thread Serge Semin
On Tue, May 19, 2020 at 10:32:46PM +0530, Vinod Koul wrote: > On 17-05-20, 22:23, Serge Semin wrote: > > On Fri, May 15, 2020 at 12:00:39PM +0530, Vinod Koul wrote: > > > Hi Serge, > > > > > > On 12-05-20, 15:42, Serge Semin wrote: > > > > Vinod, > > > > > > > > Could you join the discussion for

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-19 Thread Vinod Koul
On 17-05-20, 22:23, Serge Semin wrote: > On Fri, May 15, 2020 at 12:00:39PM +0530, Vinod Koul wrote: > > Hi Serge, > > > > On 12-05-20, 15:42, Serge Semin wrote: > > > Vinod, > > > > > > Could you join the discussion for a little bit? > > > > > > In order to properly fix the problem discussed in

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-17 Thread Serge Semin
On Fri, May 15, 2020 at 12:00:39PM +0530, Vinod Koul wrote: > Hi Serge, > > On 12-05-20, 15:42, Serge Semin wrote: > > Vinod, > > > > Could you join the discussion for a little bit? > > > > In order to properly fix the problem discussed in this topic, we need to > > introduce an additional capab

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-14 Thread Vinod Koul
Hi Serge, On 12-05-20, 15:42, Serge Semin wrote: > Vinod, > > Could you join the discussion for a little bit? > > In order to properly fix the problem discussed in this topic, we need to > introduce an additional capability exported by DMA channel handlers on > per-channel > basis. It must be a

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-12 Thread Serge Semin
Vinod, Could you join the discussion for a little bit? In order to properly fix the problem discussed in this topic, we need to introduce an additional capability exported by DMA channel handlers on per-channel basis. It must be a number, which would indicate an upper limitation of the SG list

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Mark Brown
On Mon, May 11, 2020 at 09:32:47PM +0300, Serge Semin wrote: > Thanks for the explanation. Max segment size being set to the DMA controller > generic > device should work well. There is no need in setting the transfer and messages > size limitations. Besides I don't really see the > max_transfer_

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Andy Shevchenko
On Mon, May 11, 2020 at 10:32:55PM +0300, Serge Semin wrote: > On Mon, May 11, 2020 at 04:58:53PM +0300, Andy Shevchenko wrote: > > On Mon, May 11, 2020 at 4:48 PM Serge Semin > > wrote: > > > > > > On Mon, May 11, 2020 at 12:58:13PM +0100, Mark Brown wrote: > > > > On Mon, May 11, 2020 at 05:10:1

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Andy Shevchenko
On Tue, May 12, 2020 at 12:07:14AM +0300, Andy Shevchenko wrote: > On Mon, May 11, 2020 at 10:32:55PM +0300, Serge Semin wrote: > > On Mon, May 11, 2020 at 04:58:53PM +0300, Andy Shevchenko wrote: > > > On Mon, May 11, 2020 at 4:48 PM Serge Semin > > > wrote: > > > > > > > > On Mon, May 11, 2020 a

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Serge Semin
On Mon, May 11, 2020 at 04:58:53PM +0300, Andy Shevchenko wrote: > On Mon, May 11, 2020 at 4:48 PM Serge Semin > wrote: > > > > On Mon, May 11, 2020 at 12:58:13PM +0100, Mark Brown wrote: > > > On Mon, May 11, 2020 at 05:10:16AM +0300, Serge Semin wrote: > > > > > > > Alas linearizing the SPI mess

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Serge Semin
On Mon, May 11, 2020 at 06:44:14PM +0100, Mark Brown wrote: > On Mon, May 11, 2020 at 04:45:02PM +0300, Serge Semin wrote: > > On Mon, May 11, 2020 at 12:58:13PM +0100, Mark Brown wrote: > > > > That sounds like you need to also impose a limit on the maximum message > > > size as well then, with t

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Serge Semin
On Mon, May 11, 2020 at 06:48:00PM +0100, Mark Brown wrote: > On Mon, May 11, 2020 at 04:58:53PM +0300, Andy Shevchenko wrote: > > On Mon, May 11, 2020 at 4:48 PM Serge Semin > > > > So the question is of how to export the multi-block LLP flag from DW DMAc > > > driver. Andy? > > > I'm not sure I

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Mark Brown
On Mon, May 11, 2020 at 04:58:53PM +0300, Andy Shevchenko wrote: > On Mon, May 11, 2020 at 4:48 PM Serge Semin > > So the question is of how to export the multi-block LLP flag from DW DMAc > > driver. Andy? > I'm not sure I understand why do you need this being exported. Just > always supply SG l

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Mark Brown
On Mon, May 11, 2020 at 04:45:02PM +0300, Serge Semin wrote: > On Mon, May 11, 2020 at 12:58:13PM +0100, Mark Brown wrote: > > That sounds like you need to also impose a limit on the maximum message > > size as well then, with that you should be able to handle messages up > > to whatever that limi

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Andy Shevchenko
On Mon, May 11, 2020 at 06:13:44AM +0300, Serge Semin wrote: > On Fri, May 08, 2020 at 10:06:22PM +0300, Andy Shevchenko wrote: > > On Fri, May 08, 2020 at 12:53:34PM +0100, Mark Brown wrote: > > > On Fri, May 08, 2020 at 02:26:04PM +0300, Andy Shevchenko wrote: > > > > On Fri, May 08, 2020 at 01:5

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Andy Shevchenko
On Mon, May 11, 2020 at 4:48 PM Serge Semin wrote: > > On Mon, May 11, 2020 at 12:58:13PM +0100, Mark Brown wrote: > > On Mon, May 11, 2020 at 05:10:16AM +0300, Serge Semin wrote: > > > > > Alas linearizing the SPI messages won't help in this case because the DW > > > DMA > > > driver will split

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Serge Semin
On Mon, May 11, 2020 at 12:58:13PM +0100, Mark Brown wrote: > On Mon, May 11, 2020 at 05:10:16AM +0300, Serge Semin wrote: > > > Alas linearizing the SPI messages won't help in this case because the DW DMA > > driver will split it into the max transaction chunks anyway. > > That sounds like you n

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-11 Thread Mark Brown
On Mon, May 11, 2020 at 05:10:16AM +0300, Serge Semin wrote: > Alas linearizing the SPI messages won't help in this case because the DW DMA > driver will split it into the max transaction chunks anyway. That sounds like you need to also impose a limit on the maximum message size as well then, wit

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-10 Thread Serge Semin
On Fri, May 08, 2020 at 10:06:22PM +0300, Andy Shevchenko wrote: > On Fri, May 08, 2020 at 12:53:34PM +0100, Mark Brown wrote: > > On Fri, May 08, 2020 at 02:26:04PM +0300, Andy Shevchenko wrote: > > > On Fri, May 08, 2020 at 01:53:02PM +0300, Serge Semin wrote: > > > > > > Multi-block support pro

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-10 Thread Serge Semin
Hello Mark On Fri, May 08, 2020 at 12:53:34PM +0100, Mark Brown wrote: > On Fri, May 08, 2020 at 02:26:04PM +0300, Andy Shevchenko wrote: > > On Fri, May 08, 2020 at 01:53:02PM +0300, Serge Semin wrote: > > > > Multi-block support provides a way to map the kernel-specific SG-table so > > > the DW

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-08 Thread Andy Shevchenko
On Fri, May 08, 2020 at 12:53:34PM +0100, Mark Brown wrote: > On Fri, May 08, 2020 at 02:26:04PM +0300, Andy Shevchenko wrote: > > On Fri, May 08, 2020 at 01:53:02PM +0300, Serge Semin wrote: > > > > Multi-block support provides a way to map the kernel-specific SG-table so > > > the DW DMA device

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-08 Thread Mark Brown
On Fri, May 08, 2020 at 02:26:04PM +0300, Andy Shevchenko wrote: > On Fri, May 08, 2020 at 01:53:02PM +0300, Serge Semin wrote: > > Multi-block support provides a way to map the kernel-specific SG-table so > > the DW DMA device would handle it as a whole instead of handling the > > SG-list items o

Re: [PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-08 Thread Andy Shevchenko
+Cc: Mark (question about SPI + DMA workflow) On Fri, May 08, 2020 at 01:53:02PM +0300, Serge Semin wrote: > Multi-block support provides a way to map the kernel-specific SG-table so > the DW DMA device would handle it as a whole instead of handling the > SG-list items or so called LLP block items

[PATCH v2 4/6] dmaengine: dw: Print warning if multi-block is unsupported

2020-05-08 Thread Serge Semin
Multi-block support provides a way to map the kernel-specific SG-table so the DW DMA device would handle it as a whole instead of handling the SG-list items or so called LLP block items one by one. So if true LLP list isn't supported by the DW DMA engine, then soft-LLP mode will be utilized to load