Re: [PATCH v2 4/5] x86/boot: use -fno-builtin-bcmp

2020-08-19 Thread Nick Desaulniers
On Wed, Aug 19, 2020 at 12:29 PM Arvind Sankar wrote: > > On Wed, Aug 19, 2020 at 12:16:53PM -0700, Nick Desaulniers wrote: > > We're reverting > > commit 5f074f3e192f ("lib/string.c: implement a basic bcmp") > > in favor of -fno-builtin-bcmp. Remove the additional definition here, > > too. > > >

Re: [PATCH v2 4/5] x86/boot: use -fno-builtin-bcmp

2020-08-19 Thread Arvind Sankar
On Wed, Aug 19, 2020 at 12:16:53PM -0700, Nick Desaulniers wrote: > We're reverting > commit 5f074f3e192f ("lib/string.c: implement a basic bcmp") > in favor of -fno-builtin-bcmp. Remove the additional definition here, > too. > > arch/x86/purgatory/Makefile uses -ffreestanding, so there's no risk

[PATCH v2 4/5] x86/boot: use -fno-builtin-bcmp

2020-08-19 Thread Nick Desaulniers
We're reverting commit 5f074f3e192f ("lib/string.c: implement a basic bcmp") in favor of -fno-builtin-bcmp. Remove the additional definition here, too. arch/x86/purgatory/Makefile uses -ffreestanding, so there's no risk of this libcall optimization occurring for arch/x86/boot/purgatory.ro. arch/x