Re: [PATCH v2 4/4] mm/zswap: use GFP_NOIO instead of GFP_KERNEL

2013-09-16 Thread Weijie Yang
On Tue, Sep 10, 2013 at 12:47 AM, Seth Jennings wrote: > On Fri, Sep 06, 2013 at 01:16:45PM +0800, Weijie Yang wrote: >> To avoid zswap store and reclaim functions called recursively, >> use GFP_NOIO instead of GFP_KERNEL >> >> Signed-off-by: Weijie Yang > > I agree with Bob to some degree that G

Re: [PATCH v2 4/4] mm/zswap: use GFP_NOIO instead of GFP_KERNEL

2013-09-09 Thread Seth Jennings
On Fri, Sep 06, 2013 at 01:16:45PM +0800, Weijie Yang wrote: > To avoid zswap store and reclaim functions called recursively, > use GFP_NOIO instead of GFP_KERNEL > > Signed-off-by: Weijie Yang I agree with Bob to some degree that GFP_NOIO is a broadsword here. Ideally, we'd like to continue all

Re: [PATCH v2 4/4] mm/zswap: use GFP_NOIO instead of GFP_KERNEL

2013-09-05 Thread Bob Liu
On 09/06/2013 01:16 PM, Weijie Yang wrote: > To avoid zswap store and reclaim functions called recursively, > use GFP_NOIO instead of GFP_KERNEL > The reason of using GFP_KERNEL in write back path is we want to try our best to move those pages from zswap to real swap device. I think it would be

[PATCH v2 4/4] mm/zswap: use GFP_NOIO instead of GFP_KERNEL

2013-09-05 Thread Weijie Yang
To avoid zswap store and reclaim functions called recursively, use GFP_NOIO instead of GFP_KERNEL Signed-off-by: Weijie Yang --- mm/zswap.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index cc40e6a..3d05ed8 100644 --- a/mm/zswap.c +++ b/mm